ethanlin01x commented on issue #3750: URL: https://github.com/apache/iggy/issues/3750#issuecomment-5083998527
Hi @mmmmxa, I'm a newcomer here too, so please read the below as a suggestion rather than established practice. How this actually gets split is the maintainers' call, and it's probably worth waiting for one of them to weigh in before you reorganize anything. By checklist I just meant keeping this issue as the umbrella and turning the description into `- [ ]` boxes, so each item gets closed by its own small PR without the issue count growing. Nothing more than that. On the split, your two-way version already works. If you want a finer cut, I'd split the docker half by what a reviewer has to agree with before approving. The fixes for what's broken today (seccomp, container connectivity) only need one answer: does it work now. The restructuring (Rust base image, uv cache mounts, `--locked`) needs agreement about build time and image size, which is a longer conversation. Put them in one PR and the fixes wait for that conversation to finish, which is the only reason I'd separate them. The README work is pure addition and can land whenever. Two small things worth folding in if useful: the README links to `foreign/python/CONTRIBUTING.md`, which doesn't exist in the repo, and changing the Python version anywhere trips `scripts/ci/sync-python-interpreter-version.sh` in pre-commit until every file agrees (it has a `--fix` mode). Happy to take the verification side. I'm on macOS/arm64, so I can run whatever you write from a clean clone and tell you where it breaks. Just ping me when there's a branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
