ethanlin01x commented on issue #3750: URL: https://github.com/apache/iggy/issues/3750#issuecomment-5134516176
Hi @mmmmxa, Splitting the test redesign into its own issue sounds right. One thing to check before committing to testcontainers everywhere: CI doesn't use `apache/iggy:edge`. It builds `iggy-server` from the PR's checkout with cargo (`.github/actions/utils/server-start`), and `sdk-python` has `rust-server` in its `depends_on`, so server changes deliberately run the Python suite against the freshly built server. Pulling a published image would test yesterday's edge instead of the change itself, which is the same version skew you flagged for `test_tls.py`, just applied to the whole suite. A middle path: conftest already reads `IGGY_SERVER_HOST`/`IGGY_SERVER_TCP_PORT`, so tests are connection-agnostic. Make testcontainers an opt-in fixture (spin up a container when no address is set), keep CI on the source-built server, and `test_tls.py` stops being a special case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
