mmmmxa commented on issue #3750:
URL: https://github.com/apache/iggy/issues/3750#issuecomment-5133974726
Hi @slbotbm! I have a few things to discuss.
After tinkering with the docker part I stumbled upon `test_tls.py`. In this
test, `testcontainers` spins up a container with `apache/iggy:edge` (btw this
can cause an inconsistency in Iggy versions tested when running `pytest`) with
TLS enabled. This is different from the rest of the tests that are connecting
to the non-TLS Iggy running from a user command in case of regular tests or
non-TLS Iggy running in the docker-compose. The `testcontainers` approach and
pure Docker approach are not very compatible since for `test_tls.py` the
composition process is happening inside of the test and for the rest of the
tests the composition is happening by user's command or from the compose file.
To me, this mix is not very robust and eventually will require a redesign. I
have the following suggestion of how we can go from here:
1. Create a new issue specifically for the redesign of the tests. This issue
will essentially cover only the README update without changing anything else.
2. I think that for test redesign I'd simply propose to move all tests to
`testcontainers` and getting rid of two ways that exist now (manual iggy server
start + pytest or everything in docker compose). We will essentially configure
all the tests to run the Iggy in the container and user will only have to
follow the installation requirements to make sure those containers are spinning
up correctly. It makes sense because:
- all tests are integration tests which require a running container;
- we won't have to manage two ways of testing;
- the composition process will be designed in a way that allows for more
sophisticated integration scenarios if needed.
If you are okay with this idea, I can take up this task of porting all tests
to `testcontainers`. Please let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
