ethanlin01x commented on code in PR #3992: URL: https://github.com/apache/iggy/pull/3992#discussion_r3888969924
########## foreign/python/tests/test_http_config.py: ########## @@ -0,0 +1,145 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Tests for the HTTP client configuration surface. + +`HttpConfig` mirrors the Rust SDK's `HttpClientConfig` the same way +`TcpConfig`/`QuicConfig` do, so most of these assert that a value set from +Python survives to the getters and that unset fields fall back to the Rust +defaults. HTTP is stateless per-request, so unlike TCP/QUIC there is no +`AutoLogin` or reconnection policy to configure. +""" + +import ast +from datetime import timedelta + +import pytest + +from apache_iggy import HttpConfig, IggyClient + +from .utils import get_http_server_config, wait_for_ping + + [email protected] +class TestHttpConfig: + """Test the transport configuration.""" + + def test_defaults_match_the_rust_sdk(self): + """Test that an unconfigured transport matches the Rust SDK defaults.""" + config = HttpConfig() + + assert config.api_url == "http://127.0.0.1:3000"; + assert config.retries == 3 + assert config.has_jwt is False Review Comment: Also check `heartbeat_interval` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
