saie-ch commented on code in PR #3992:
URL: https://github.com/apache/iggy/pull/3992#discussion_r3944098682
##########
foreign/python/src/config.rs:
##########
@@ -408,16 +409,127 @@ impl TcpConfig {
}
}
+/// Configuration for the HTTP transport, accepted by `IggyClient(...)`.
Review Comment:
I went to add a test for this and couldn't reproduce the empty result. Same
server, same stream/topic, same call, only the transport differs:
group EXISTS (2 messages produced, partition 0)
HTTP group poll -> 2 message(s)
TCP group poll -> 0 message(s)
TCP behaves exactly as you describe. HTTP returns the full batch.
As far as I can tell the fence never runs over HTTP: `Consumer::kind` is
`#[serde(skip)]`, so the kind never reaches the server and the poll takes
the
plain-consumer path, served as an ordinary consumer named after the group.
I've kept "single-consumer only" but reworded the reason. Am I reading this
right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
