saie-ch commented on code in PR #3992: URL: https://github.com/apache/iggy/pull/3992#discussion_r3944138701
########## foreign/python/README.md: ########## @@ -168,6 +168,11 @@ async def main(): asyncio.run(main()) ``` +`IggyClient(...)` also accepts an `HttpConfig` for the HTTP transport. HTTP is a +stateless per-request transport, so there is no reconnection policy to configure. +There is also no `AutoLogin`: call `login_user(...)` explicitly after connecting. Review Comment: HttpClient::connect() is a no-op, but IggyClient::connect() isn't—the latter starts the heartbeat configured by heartbeat_interval. So the README now instructs users to call connect() followed by login_user(...), rather than using one instead of the other. Is this approach fine for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
