Elioooon commented on PR #4017: URL: https://github.com/apache/iggy/pull/4017#issuecomment-5549424769
Addressed the requested changes in 67df430. The server-side root cause was that `remove_partitions_from` evicted deleted `PartitionStats` entries without first rolling their counters out of the parent `TopicStats` and `StreamStats`. It now detaches entries under the registry lock, releases the lock, then calls `zero_out_all()` on each removed counter. Replayed left-right applies remain idempotent because the entries are already absent. I also tightened the Python contract and tests: numeric IDs now assert the intermediate created state; error tests match specific server messages; invalid identifiers, Python integer overflow, delete-all, and a message-bearing new partition are covered; the API docs include count bounds, partition IDs, consumer-group effects, asynchronous teardown, and exceptions. Local validation: - `cargo fmt --all -- --check` - `cargo clippy -p metadata --all-targets -- -D warnings` - `cargo test -p metadata` (146 passed) - `cargo clippy --lib -- -D warnings` from `foreign/python` - `cargo check --lib` from `foreign/python` - targeted whitespace/newline checks The Python integration suite and generated-stub consistency are left to the standard CI environment because this host has Python 3.7 shared (below PyO3 minimum) and Python 3.13 static (not linkable into the extension). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
