ryerraguntla commented on code in PR #4043: URL: https://github.com/apache/iggy/pull/4043#discussion_r4020483466
########## gateways/kafka/tests/bridge_iggy_integration_tests.rs: ########## @@ -0,0 +1,918 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Integration tests for `IggyBridge` against a real `iggy-server` process - not the +//! `KafkaGateway` under test elsewhere in this suite. `#3533` acceptance criteria this file +//! exercises directly: `ensure_stream_and_topic` idempotent on repeated calls, and the bridge +//! module invoked from a real (non-unit) test rather than only compiled. + +use std::collections::HashMap; +use std::fs::{File, OpenOptions}; +use std::path::PathBuf; +use std::process::{Child, Command}; +use std::sync::OnceLock; +use std::time::Duration; + +use iggy::prelude::{ + AutoLogin, Client, Credentials, Identifier, IggyClient, IggyClientBuilder, IggyMessage, + MessageClient, Partitioning, StreamClient, TopicClient, +}; +use secrecy::SecretString; +use serial_test::serial; + +use iggy_gateway_kafka::bridge::{ + BridgeError, IggyBridge, IggyBridgeConfig, TopicMapping, TopicOverride, +}; + +/// Desired slot count - the actual count `port_band()` computes may be smaller if the machine's +/// real ephemeral range leaves little room, but this crate never needs more than a handful live +/// at once (this binary's own tests already run one at a time - see `.config/nextest.toml`'s +/// `kafka_bridge` test-group). +const DESIRED_SLOTS: u16 = 200; + +/// Lowest port `port_band()` will ever place its band at - clear of the well-known/privileged +/// range (0-1023). +const MIN_CANDIDATE_PORT: u16 = 10000; + +/// Ephemeral range assumed when the kernel's own can't be read (no `/proc` - e.g. macOS), +/// matching the Linux default. Mirrors `core/integration`'s own `port_reserver.rs`. +const DEFAULT_EPHEMERAL_RANGE: (u16, u16) = (32768, 60999); + +const IP_LOCAL_PORT_RANGE: &str = "/proc/sys/net/ipv4/ip_local_port_range"; + +fn parse_ephemeral_range(range: &str) -> Option<(u16, u16)> { + let mut bounds = range.split_whitespace(); + let floor: u16 = bounds.next()?.parse().ok()?; + let ceiling: u16 = bounds.next()?.parse().ok()?; + Some((floor, ceiling)) +} + +/// The range the kernel picks `bind(0)` ports from, read once. +fn ephemeral_range() -> (u16, u16) { + static RANGE: OnceLock<(u16, u16)> = OnceLock::new(); + *RANGE.get_or_init(|| { + std::fs::read_to_string(IP_LOCAL_PORT_RANGE) + .ok() + .as_deref() + .and_then(parse_ephemeral_range) + .unwrap_or(DEFAULT_EPHEMERAL_RANGE) + }) +} + +/// First port and slot count of a band clear of the kernel's ephemeral range: below the floor by +/// preference (matches `core/integration`'s own `port_reserver.rs`), above the ceiling when the +/// floor leaves no room there. +/// +/// A *hardcoded* band, chosen once without reading the real range (this file's own prior version: +/// `15000..15199`, on the unverified assumption that every real deployment's floor sits above +/// it), is wrong on any box tuned wider - `net.ipv4.ip_local_port_range = "1024 65535"` swallows +/// that whole band. `flock` alone doesn't save it either: it is advisory, so it only excludes +/// another `PortGuard`-based process, never an unrelated `bind(0)` elsewhere on the box landing on +/// the same number from the kernel's own ephemeral pool. +fn port_band() -> (u16, u16) { + static BAND: OnceLock<(u16, u16)> = OnceLock::new(); + *BAND.get_or_init(|| { + let (floor, ceiling) = ephemeral_range(); + band_for(floor, ceiling) + }) +} + +/// Pure band-selection logic, split out from [`port_band`] so it's testable against synthetic +/// ranges without needing to fake `/proc` contents. +fn band_for(floor: u16, ceiling: u16) -> (u16, u16) { + if floor > MIN_CANDIDATE_PORT { + let room = floor - MIN_CANDIDATE_PORT; + return (MIN_CANDIDATE_PORT, room.min(DESIRED_SLOTS)); + } + let Some(start) = ceiling.checked_add(1) else { + panic!( + "kernel ephemeral range [{floor}, {ceiling}] leaves no room for a test port band \ + below {MIN_CANDIDATE_PORT} nor above {ceiling} - narrow the range, e.g. \ + sysctl -w net.ipv4.ip_local_port_range='32768 60999'" + ); + }; + // start >= 1 (ceiling + 1), so this never overflows u16. + let room = u16::MAX - start + 1; + (start, room.min(DESIRED_SLOTS)) +} + +#[test] +fn given_a_readable_range_when_parsed_should_take_both_bounds() { + assert_eq!( + parse_ephemeral_range("32768\t60999\n"), + Some((32768, 60999)) + ); + assert_eq!(parse_ephemeral_range("1024 65535"), Some((1024, 65535))); + assert_eq!(parse_ephemeral_range(""), None); + assert_eq!(parse_ephemeral_range("32768"), None); + assert_eq!(parse_ephemeral_range("garbage 60999"), None); +} + +#[test] +fn given_room_below_the_floor_when_choosing_a_band_should_take_it() { + let (start, slots) = band_for(32768, 60999); + assert_eq!(start, MIN_CANDIDATE_PORT); + assert!( + start + slots <= 32768, + "band [{start}, {}] runs into the ephemeral floor", + start + slots - 1 + ); +} + +/// A box tuned `net.ipv4.ip_local_port_range = "1024 60999"` is exactly the case the prior +/// hardcoded `15000..15199` band silently broke under: room below the floor down to +/// `MIN_CANDIDATE_PORT` is gone, but the ceiling still leaves room above it. +#[test] +fn given_no_room_below_the_floor_when_choosing_a_band_should_fall_back_above_the_ceiling() { + let (start, slots) = band_for(1024, 60999); + assert!(slots > 0, "must find room above the ceiling, not just fail"); + assert!( + start > 60999, + "band must start above the ephemeral ceiling, got {start}" + ); +} + +#[test] +#[should_panic(expected = "leaves no room")] +fn given_no_room_on_either_side_when_choosing_a_band_should_fail_loudly() { + band_for(1024, u16::MAX); +} + +/// Exclusive claim on one port, released (and the port freed for reuse) when dropped - including +/// on an unclean process exit, since the OS drops the `flock` with the file descriptor. Unlike +/// bind-then-drop, this process itself never binds the port before `iggy-server` does; see +/// `port_band`'s doc comment for the limits of that guarantee against *other* processes. +struct PortGuard { + port: u16, + _lock: File, +} + +impl PortGuard { + fn acquire() -> Self { + let (band_start, band_slots) = port_band(); + let lock_dir = std::env::temp_dir().join("iggy-kafka-gateway-test-port-locks"); + std::fs::create_dir_all(&lock_dir).expect("create port lock dir"); + for offset in 0..band_slots { + let port = band_start + offset; + let path = lock_dir.join(format!("{port}.lock")); + let Ok(file) = OpenOptions::new() + .read(true) + .write(true) + .create(true) + .truncate(false) + .open(&path) + else { + continue; + }; + if file.try_lock().is_ok() { + return Self { port, _lock: file }; + } + } + panic!( + "no free port slot in [{band_start}, {}]", + band_start + band_slots - 1 + ); + } +} + +/// Locates the already-built `iggy-server` binary. Does not build it - see this crate's +/// `docs/TEST_SUITE.md` for the prerequisite, the same one `core/integration`'s own +/// server-spawning tests already carry. +/// +/// `assert_cmd::cargo::cargo_bin`, matching `core/integration`'s own +/// `harness::handle::server::start` - not a from-scratch `cargo build` invocation. An earlier +/// version of this function drove `cargo build --package server --bin iggy-server` directly, +/// reasoning that `Command::cargo_bin` "only resolves `CARGO_BIN_EXE_*` for binaries owned by +/// *this* package" - true of the `CARGO_BIN_EXE_*` env-var lookup alone, but `cargo_bin` falls +/// back to `legacy_cargo_bin` when that's unset, which derives the target directory from +/// `env::current_exe()` (this test binary's own path) and looks for a same-named file there - +/// correct under `CARGO_TARGET_DIR`, `--release`, or a `--target` triple subdirectory precisely +/// because it reads back from where cargo actually placed *this* binary, not a guessed path. That +/// version also re-ran a `cargo build` from every one of this file's server-spawning tests +/// (nextest runs each as its own process, so the `OnceLock` memoized nothing across them), +/// serialized by `.config/nextest.toml`'s `kafka_bridge` test-group but still real, avoidable +/// per-test overhead this version has none of. +fn iggy_server_binary() -> PathBuf { + assert_cmd::cargo::cargo_bin("iggy-server") +} + +struct TestServer { + child: Child, + address: String, + password: String, + _port_guard: PortGuard, +} + +impl TestServer { + /// Spawns `iggy-server` with the default `iggy`/`iggy` root credentials. See + /// [`Self::spawn_with_password`] for the general form. + async fn spawn(data_dir: &std::path::Path) -> Self { + Self::spawn_with_password(data_dir, "iggy").await + } + + /// Spawns `iggy-server` with an isolated temp data dir, a locked TCP port, and the given root + /// password, then blocks until its listener is ready or the startup budget is exhausted. + /// + /// A dedicated password parameter (not just the `spawn()` default everywhere) lets a + /// password-shaped regression test (special characters, say) reuse this harness's + /// `PortGuard`/graceful-`Drop`/`wait_ready` machinery instead of hand-rolling a second, + /// `Drop`-less spawn: a `Drop`-less copy has no guard to run `graceful_kill` on a panic before + /// its assertions, orphaning a process that still holds its `PortGuard` slot, which then + /// fails the next test that draws that slot to bind. + async fn spawn_with_password(data_dir: &std::path::Path, password: &str) -> Self { + let port_guard = PortGuard::acquire(); + let address = format!("127.0.0.1:{}", port_guard.port); + + let mut command = Command::new(iggy_server_binary()); + command + .env("IGGY_PATH", data_dir.display().to_string()) + .env("IGGY_TCP_ADDRESS", &address) + .env("IGGY_HTTP_ENABLED", "false") + .env("IGGY_QUIC_ENABLED", "false") + // WebSocket defaults to enabled on a fixed 127.0.0.1:8092 (config.toml), unlike TCP + // which reads a per-test port from PortGuard - every spawned server here would fight + // over that one port otherwise, and a bind failure aborts boot. + .env("IGGY_WEBSOCKET_ENABLED", "false") + // Matches core/integration's own spawned-server harness (harness/handle/server.rs): + // pinned shards (config.toml default: pin_cores = true) of concurrently running + // servers pile onto the same cores and starve each other. This crate's own tests are + // serialized against each other (.config/nextest.toml's kafka_bridge test-group - + // #[serial] alone does not survive nextest, which runs each test as its own process), + // but a spawned server here can still land alongside a pinned server from a different + // package's test in the same nextest run. + .env("IGGY_SHARDING_PIN_CORES", "false") + // `--with-default-root-credentials` is off by default (args.rs) - without these, + // a fresh server provisions no loginable root user at all, and every bridge connect + // attempt fails with "invalid credentials" no matter what this test passes. + .env("IGGY_ROOT_USERNAME", "iggy") + .env("IGGY_ROOT_PASSWORD", password); + let child = command.spawn().expect("spawn iggy-server"); + + let mut server = Self { + child, + address, + password: password.to_string(), + _port_guard: port_guard, + }; + server.wait_ready().await; + server + } + + /// Polls with a bare TCP connect, not a full `IggyBridge::connect`: the latter carries + /// `RECONNECTION_RETRIES` (3 dials at ~1s apart) on every failed attempt, so a poll loop built + /// on it pays several real seconds per iteration instead of running at its own 100ms cadence, + /// and a *successful* poll iteration would authenticate a client and then drop it without + /// `close()`, leaking a session server-side. A TCP accept slightly ahead of the app being + /// ready to authenticate is fine - every caller's own subsequent `IggyBridge::connect` already + /// retries a few times, which covers the last few hundred ms of that gap. + /// + /// Checks `try_wait()` every iteration: a server that fails at boot (bad config, a port + /// stolen between `PortGuard::acquire` and its own bind) exits almost immediately, and without + /// this check that reads as "still starting" for the full 30s budget - the eventual failure + /// names the wrong cause ("did not become ready") instead of the real one (exited early, with + /// whatever it printed before dying). + async fn wait_ready(&mut self) { + let deadline = tokio::time::Instant::now() + Duration::from_secs(30); + loop { + if let Some(status) = self.child.try_wait().expect("poll child status") { + panic!( + "iggy-server at {} exited during startup with {status}", + self.address + ); + } + if tokio::net::TcpStream::connect(self.address.as_str()) + .await + .is_ok() + { + return; + } + assert!( + tokio::time::Instant::now() < deadline, + "iggy-server at {} did not become ready within the startup budget", + self.address + ); + tokio::time::sleep(Duration::from_millis(100)).await; + } + } + + fn test_config(&self) -> IggyBridgeConfig { + IggyBridgeConfig { + address: self.address.clone(), + username: "iggy".to_string(), + password: SecretString::from(self.password.clone()), + topic_mapping: TopicMapping::new("kafka".to_string(), HashMap::new()) + .expect("valid mapping for this test's fixture data"), + } + } +} + +/// SIGTERM, wait up to `SIGTERM_TIMEOUT`, then SIGKILL if it hasn't exited. Mirrors +/// `core/integration`'s own `harness::handle::common::graceful_kill` (not reused directly - that +/// crate is heavyweight, and pulling it in for one function isn't worth it; this crate already +/// depends directly on `iggy`/`core/sdk`, so `core/integration` wouldn't add a *new* +/// core/sdk-change-reruns-these-tests edge, just an unrelated dependency). A bare SIGKILL skips +/// `iggy-server`'s shutdown path entirely, which is a materially different exit than what the +/// binary is actually built to do on `SIGTERM` - `.kill()` alone bypassed that in every test run +/// before this fix. +const SIGTERM_TIMEOUT: Duration = Duration::from_secs(5); +const SIGKILL_POLL_INTERVAL: Duration = Duration::from_millis(50); + +fn graceful_kill(child: &mut Child) { + // `wait_ready` calls `try_wait()` too (and panics on an early exit, unwinding into this via + // `Drop`) - if it already reaped the child, `child.id()` is a PID the OS is free to hand to an + // unrelated process by the time we get here, and a raw `libc::kill` (unlike `std::Child::kill`, + // which checks its own cached exit status first and no-ops instead) has no such guard against + // signaling that PID anyway. Checking here first closes the same gap `std` already closes for + // its own `kill`. + if matches!(child.try_wait(), Ok(Some(_))) { + return; + } + + let pid = child.id() as libc::pid_t; + // Safety: `pid` is this process's own live child, confirmed by the `try_wait` check above; + // sending it a signal is exactly what `Child::kill` itself does internally. + unsafe { + libc::kill(pid, libc::SIGTERM); + } + + let deadline = std::time::Instant::now() + SIGTERM_TIMEOUT; + while std::time::Instant::now() < deadline { + match child.try_wait() { + Ok(None) => std::thread::sleep(SIGKILL_POLL_INTERVAL), + Ok(Some(_)) | Err(_) => return, + } + } + + let _ = child.kill(); +} + +impl Drop for TestServer { + fn drop(&mut self) { + graceful_kill(&mut self.child); + let _ = self.child.wait(); + } +} + +/// Builds and connects a raw `IggyClient` against `server` - for producing test data directly, +/// independent of the `IggyBridge` under test. Uses the fluent builder, not a hand-built +/// `iggy://user:pass@host` string: `ConnectionString` splits on `@` then `:`, which breaks for +/// any password containing either character. +async fn raw_client(server: &TestServer) -> IggyClient { + let client = IggyClientBuilder::new() + .with_tcp() + .with_server_address(server.address.clone()) + .with_auto_sign_in(AutoLogin::Enabled(Credentials::UsernamePassword( + "iggy".to_string(), + SecretString::from("iggy"), + ))) + .build() + .expect("build raw test client"); + client.connect().await.expect("connect raw test client"); + client +} + +#[tokio::test] +#[serial] +async fn ensure_stream_and_topic_is_idempotent_on_repeated_calls() { + let data_dir = tempfile::tempdir().expect("tempdir"); + let server = TestServer::spawn(data_dir.path()).await; + let bridge = IggyBridge::connect(server.test_config()) + .await + .expect("bridge should connect to a ready server"); + + bridge + .ensure_stream_and_topic("orders", 3) + .await + .expect("first call creates the stream and topic"); + bridge + .ensure_stream_and_topic("orders", 3) + .await + .expect("second call is a no-op against the now-existing stream and topic"); + bridge + .ensure_stream_and_topic("orders", 3) + .await + .expect("third call is still a no-op"); + + // Read back real state, not just three Oks: proves the second and third calls were actually + // no-ops against the one topic the first call created, not e.g. three independent topics + // that all happen to satisfy Ok(()) individually. + let raw = raw_client(&server).await; + let topics = raw + .get_topics(&Identifier::named("kafka").expect("valid stream name")) + .await + .expect("get_topics call"); + assert_eq!(topics.len(), 1, "must be exactly one topic, not three"); + assert_eq!(topics[0].name, "orders"); + assert_eq!(topics[0].partitions_count, 3); +} + +/// Regression test for coverage: nothing previously exercised `PartitionCountMismatch` on a real +/// server - only unit tests constructed the variant directly. +#[tokio::test] +#[serial] +async fn ensure_stream_and_topic_rejects_a_second_call_with_a_different_partition_count() { + let data_dir = tempfile::tempdir().expect("tempdir"); + let server = TestServer::spawn(data_dir.path()).await; + let bridge = IggyBridge::connect(server.test_config()) + .await + .expect("bridge should connect to a ready server"); + + bridge + .ensure_stream_and_topic("orders", 3) + .await + .expect("first call creates the topic with 3 partitions"); + + let err = bridge + .ensure_stream_and_topic("orders", 5) + .await + .expect_err( + "a different partition count against an existing topic must not silently succeed", + ); + match err { + BridgeError::PartitionCountMismatch { + topic, + existing, + requested, + } => { + assert_eq!(topic, "orders", "must report the Kafka-side name"); + assert_eq!(existing, 3); + assert_eq!(requested, 5); + } + other => panic!("expected PartitionCountMismatch, got {other:?}"), + } +} + +/// Regression test for coverage: every other test uses an empty `TopicMapping` (`HashMap::new()`), +/// so the Kafka-name-vs-Iggy-name distinction `ensure_topic`/`high_watermark` deliberately +/// maintain in their error paths (`kafka_topic`, not the resolved `topic_name`) can never actually +/// differ and so can never be caught wrong. This test maps a Kafka topic to a differently-named +/// Iggy stream/topic and checks both the happy path and the error paths report the Kafka-side +/// name a real caller (a future handler) would recognize. +#[tokio::test] +#[serial] +async fn bridge_operations_report_the_kafka_side_name_through_a_real_topic_mapping_override() { + let data_dir = tempfile::tempdir().expect("tempdir"); + let server = TestServer::spawn(data_dir.path()).await; + let mut config = server.test_config(); + let mut topics = HashMap::new(); + topics.insert( + "orders".to_string(), + TopicOverride { + stream: "billing".to_string(), + topic: "orders_v2".to_string(), + }, + ); + config.topic_mapping = TopicMapping::new("kafka".to_string(), topics) + .expect("valid mapping for this test's fixture data"); + let bridge = IggyBridge::connect(config) + .await + .expect("bridge should connect to a ready server"); + + bridge + .ensure_stream_and_topic("orders", 1) + .await + .expect("must create the mapped Iggy stream/topic, not one named after the Kafka topic"); + + // The Iggy-side resources are named differently from the Kafka topic - confirms the mapping + // actually took effect, not that resolve() was a no-op that happened to pass either way. + let raw = raw_client(&server).await; + let billing_topics = raw + .get_topics(&Identifier::named("billing").expect("valid stream name")) + .await + .expect("get_topics call"); + assert_eq!(billing_topics.len(), 1); + assert_eq!(billing_topics[0].name, "orders_v2"); + + let watermark = bridge + .high_watermark("orders", 0) + .await + .expect("must resolve through the mapping, not fail looking for a stream named 'orders'"); + assert_eq!(watermark, 0); + + let out_of_range = bridge + .high_watermark("orders", 5) + .await + .expect_err("partition 5 does not exist on a 1-partition topic"); + assert!( + matches!( + &out_of_range, + BridgeError::PartitionOutOfRange { topic, .. } if topic == "orders" + ), + "error must quote the Kafka topic name 'orders', not the Iggy name 'orders_v2': \ + {out_of_range:?}" + ); + + let mismatch = bridge + .ensure_stream_and_topic("orders", 2) + .await + .expect_err("different partition count against the mapped topic must not silently succeed"); + assert!( + matches!( + &mismatch, + BridgeError::PartitionCountMismatch { topic, .. } if topic == "orders" + ), + "error must quote the Kafka topic name 'orders', not the Iggy name 'orders_v2': \ + {mismatch:?}" + ); +} + +#[tokio::test] +#[serial] +async fn high_watermark_is_zero_for_a_fresh_empty_partition() { + let data_dir = tempfile::tempdir().expect("tempdir"); + let server = TestServer::spawn(data_dir.path()).await; + let bridge = IggyBridge::connect(server.test_config()) + .await + .expect("bridge should connect to a ready server"); + + bridge + .ensure_stream_and_topic("orders", 1) + .await + .expect("stream and topic must exist before checking the watermark"); + + let watermark = bridge + .high_watermark("orders", 0) + .await + .expect("fresh topic must report a watermark, not an error"); + assert_eq!( + watermark, 0, + "a freshly created, empty partition's high watermark must be 0" + ); +} + +/// Pins the exact semantics of `Iggy::Partition::current_offset` (offset of the *last written* +/// message, not Kafka's "next offset to produce") against a real server - a test that only +/// checked the empty-topic case would pass under either interpretation and hide an off-by-one. +#[tokio::test] +#[serial] +async fn high_watermark_reflects_produced_messages() { + let data_dir = tempfile::tempdir().expect("tempdir"); + let server = TestServer::spawn(data_dir.path()).await; + let bridge = IggyBridge::connect(server.test_config()) + .await + .expect("bridge should connect to a ready server"); + + bridge + .ensure_stream_and_topic("orders", 1) + .await + .expect("stream and topic must exist before producing"); + + let stream_id = Identifier::named("kafka").expect("valid stream name"); + let topic_id = Identifier::named("orders").expect("valid topic name"); + let mut messages: Vec<IggyMessage> = (0..3) + .map(|i| IggyMessage::from(format!("message-{i}"))) + .collect(); + let client = raw_client(&server).await; + client + .send_messages( + &stream_id, + &topic_id, + &Partitioning::partition_id(0), + &mut messages, + ) + .await + .expect("send 3 messages"); + + let watermark = bridge + .high_watermark("orders", 0) + .await + .expect("topic must report a watermark after producing"); + assert_eq!( + watermark, 3, + "high watermark after 3 messages (offsets 0, 1, 2) must be 3, not the last offset (2)" + ); +} + +#[tokio::test] +#[serial] +async fn high_watermark_rejects_out_of_range_partition() { + let data_dir = tempfile::tempdir().expect("tempdir"); + let server = TestServer::spawn(data_dir.path()).await; + let bridge = IggyBridge::connect(server.test_config()) + .await + .expect("bridge should connect to a ready server"); + + bridge + .ensure_stream_and_topic("orders", 1) + .await + .expect("stream and topic must exist before checking the watermark"); + + let err = bridge + .high_watermark("orders", 5) + .await + .expect_err("partition 5 does not exist on a 1-partition topic"); + assert!(matches!(err, BridgeError::PartitionOutOfRange { .. })); +} + +#[tokio::test] +#[serial] +async fn ensure_stream_and_topic_is_idempotent_for_a_numeric_topic_name() { + // Regression test: Identifier::try_from/FromStr parses an all-digit string as a numeric ID, + // not a name - a second call for the same numeric-named topic would look it up by the wrong + // resource kind and fail with StreamIdNotFound/TopicIdNotFound despite the topic existing. + let data_dir = tempfile::tempdir().expect("tempdir"); + let server = TestServer::spawn(data_dir.path()).await; + let bridge = IggyBridge::connect(server.test_config()) + .await + .expect("bridge should connect to a ready server"); + + bridge + .ensure_stream_and_topic("2024", 1) + .await + .expect("first call creates the numeric-named stream and topic"); + bridge + .ensure_stream_and_topic("2024", 1) + .await + .expect("second call must still find the numeric-named topic by name, not by ID"); +} + +/// Regression test: `ensure_stream` used to hand `ensure_topic` the stream's *numeric* id +/// (`Identifier::numeric`), and streams are backed by a recycled slab (freed keys are reused by +/// the next created stream) - a stream deleted and recreated between the two calls would leave +/// `ensure_topic` writing into whatever stream now holds that recycled numeric key, not the one +/// `ensure_stream_and_topic`'s caller actually resolved. The fix threads the *named* `Identifier` +/// through instead. This does not (cannot, from a black-box test) hit the exact `await` window the +/// bug lived in, but it does prove the name, not a captured numeric id, is what actually governs: +/// delete the stream, recreate it under the same name, and the very next call must still land the +/// topic on the live incarnation. +#[tokio::test] +#[serial] +async fn ensure_topic_targets_the_streams_live_incarnation_after_a_delete_and_recreate() { Review Comment: fixed.this scenario is black-box untestable given private methods with no await seam; explains what the test actually proves. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
