TomPlanche commented on issue #4287: URL: https://github.com/apache/iggy/issues/4287#issuecomment-5889200956
Discussed on Discord with @hubcio: - The first PR adds the failing tests, marked using `#[ignore]`. It keeps a trace in the code saying that the lifecycle is broken. - Problem 2: `disconnect_relogin.rs` is the correct contract. `disconnect()` holds until `connect()`. Stopping the heartbeat is not enough. - Problem 3: after `disconnect()`, `ping()` and `get_stats()` must fail on the SDK side, with no packets on the wire, no implicit wait and no reconnect. The tests PR covers this case too. - The fix for problem 2 must also update the Python and C++ docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
