TomPlanche commented on issue #4287: URL: https://github.com/apache/iggy/issues/4287#issuecomment-5998796616
@hubcio @numinnex @jiengup the review of #4388 shows that the caller-intent flag must be re-checked at every step of the reconnect sweep (before each dial, after each retry sleep, before sign-in), on TCP, QUIC and WebSocket. Otherwise a disconnect during a sweep either redials forever or gets undone. This overlaps with #4345 (bounded connect and login) and with problems 5 to 8 here. How do you want this scoped? 1. Fix everything in #4388 now: the per-step checks, the redirect path, the heartbeat teardown, and the QUIC and WebSocket ladders. 2. Wait for #4345, then add the intent checks on top of its new sweep, so the two changes do not fight over the same loops. 3. Keep #4388 small: the entry checks plus the regression fix only, and move the sweep re-checks to the PRs for problems 5 and 6. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
