github-actions[bot] commented on code in PR #4401:
URL: https://github.com/apache/iggy/pull/4401#discussion_r4180086300


##########
gateways/kafka/src/group/state.rs:
##########
@@ -708,6 +819,26 @@ fn join_request_error(config: &GroupCoordinatorConfig, 
request: &JoinRequest) ->
     None
 }
 
+/// `protocol_type`, a client-supplied `member_id`, and `group_instance_id` 
are echoed as legacy
+/// strings. When the member id is generated, the instance id is the prefix 
and the `-{uuid}`
+/// suffix has to fit in the same cap.
+fn legacy_strings_too_long(request: &JoinRequest) -> bool {

Review Comment:
   warning: `legacy_strings_too_long()` caps `protocol_type`, `member_id` and 
`group_instance_id`, but a protocol name past `i16::MAX` passes because only 
the aggregate `max_member_blob_bytes` (64 KiB) cap bounds it. `DescribeGroups` 
v0-v4 encode that name as `protocol_data` with an i16 length, so 
`kafka_protocol` cannot encode the response and `respond_or_close()` closes the 
connection. Reject a protocol name longer than `MAX_LEGACY_STRING_BYTES`.



##########
gateways/kafka/src/group/mod.rs:
##########
@@ -467,6 +537,19 @@ enum Parked<T> {
     Wait(StrBytes, Instant, watch::Receiver<u64>),
 }
 
+/// First-seen order, one entry per id. `DescribeGroups` answers a repeated id 
once: a second
+/// snapshot of the same members would multiply the encoded response by the 
repeat count.
+pub(crate) fn distinct_group_ids(group_ids: &[StrBytes]) -> Vec<StrBytes> {

Review Comment:
   simplification: `distinct_group_ids()` repeats `dedup_topic_names()` 
(protocol/handlers/metadata.rs:358), which already keeps first-seen order. Move 
one helper to a shared module and call it from both, since the metadata one 
avoids a clone per id.



##########
gateways/kafka/src/protocol/handlers/describe_groups.rs:
##########
@@ -0,0 +1,160 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! `DescribeGroups` (API key 15).
+//!
+//! Reports the members, assignment and state of groups this coordinator 
holds. A named group
+//! that is not here is `Dead`: v6 also carries `GROUP_ID_NOT_FOUND`, and 
earlier versions do
+//! not, matching Kafka 4.0's `describeGroups`. A v6 client treats error 0 as 
a real group.
+//!
+//! `include_authorized_operations` is not answered. The field stays at the 
omitted sentinel
+//! (`i32::MIN`): there is no group ACL bitfield to report, and any other 
value fails the
+//! encoder below v3.
+
+use bytes::Bytes;
+use kafka_protocol::messages::describe_groups_response::{DescribedGroup, 
DescribedGroupMember};
+use kafka_protocol::messages::{DescribeGroupsRequest, DescribeGroupsResponse, 
GroupId};
+use kafka_protocol::protocol::StrBytes;
+
+use crate::error::Result;
+use crate::group::{DescribeGroupsView, GroupDescription, MemberDescription, 
distinct_group_ids};
+use crate::protocol::api::{
+    API_KEY_DESCRIBE_GROUPS, ApiVersionRange, ERROR_GROUP_ID_NOT_FOUND, 
ERROR_UNSUPPORTED_VERSION,
+    GatewayState, HandleOutcome, is_supported_version,
+};
+use crate::protocol::bounds_guard::validate_describe_groups_shape;
+use crate::protocol::handlers::{
+    decode_guarded, encode_message, respond_or_close, 
unsupported_version_response,
+};
+
+pub const RANGE: ApiVersionRange = ApiVersionRange {
+    api_key: API_KEY_DESCRIBE_GROUPS,
+    min_version: 0,
+    max_version: 6,
+};
+
+/// Kafka's `Dead` state. This coordinator never stores it: an absent group is 
reported as one.
+const DEAD: &str = "Dead";
+/// First version whose response has `error_message`, and the first on which 
Kafka 4.0 sends
+/// `GROUP_ID_NOT_FOUND` for a missing group.
+const FIRST_ERROR_MESSAGE_VERSION: i16 = 6;
+
+pub async fn handle(state: &GatewayState, api_version: i16, body: Bytes) -> 
HandleOutcome {
+    if !is_supported_version(API_KEY_DESCRIBE_GROUPS, api_version) {
+        return unsupported_version_response(API_KEY_DESCRIBE_GROUPS, 
api_version, |version| {
+            encode_error_response(version, ERROR_UNSUPPORTED_VERSION)
+        });
+    }
+    let request =
+        match decode_guarded::<DescribeGroupsRequest>(api_version, body, 
|version, body| {
+            validate_describe_groups_shape(version, body, state.max_frame_size)
+        }) {
+            Ok(request) => request,
+            Err(error) => {
+                // debug!, not warn!: attacker-controlled, not 
operator-actionable.
+                // The response has no top-level error field, and a failed 
decode yields no group
+                // id to hang `INVALID_REQUEST` on. An empty group list would 
look like success.
+                tracing::debug!(%error, api_version, "Failed to decode 
DescribeGroups request");
+                return HandleOutcome::Close;
+            }
+        };
+
+    let requested: Vec<StrBytes> = request
+        .groups
+        .iter()
+        .map(|group_id| group_id.0.clone())
+        .collect();
+    // One result per distinct id. Repeating one group would otherwise copy 
its members into the
+    // response once per copy, and the shape guard only charges the id strings.
+    let group_ids = distinct_group_ids(&requested);

Review Comment:
   nit: The handler answers a repeated group id once, so the response holds 
fewer entries than the request. The Admin views section of 
`docs/CONSUMER_GROUPS.md` does not mention that. Add one line about repeated 
ids there.



##########
gateways/kafka/src/group/mod.rs:
##########
@@ -451,6 +489,38 @@ impl GroupCoordinator {
         state::leave_step(&mut groups, request, Instant::now())
     }
 
+    /// Snapshot of each distinct group, in first-seen order. `None` means the 
group is not here.
+    ///
+    /// Ids are deduped before the lock is taken. Under the lock each 
remaining group is ticked
+    /// once and, when the encoded response fits `max_frame_size`, snapshotted 
once. Encoding
+    /// happens after this returns. `ExceedsFrame` means the lengths already 
stored would not
+    /// fit, and no member snapshot was built.
+    pub async fn describe_groups(
+        &self,
+        group_ids: &[StrBytes],
+        version: i16,
+        max_frame_size: usize,
+    ) -> DescribeGroupsView {
+        let group_ids = distinct_group_ids(group_ids);

Review Comment:
   simplification: This `distinct_group_ids()` call is redundant: the handler 
already deduped the ids (describe_groups.rs:83), and `state::describe_groups()` 
dedupes them again under the lock. Delete this call and let the state function 
own the rule, which its snapshot-once test pins.



##########
gateways/kafka/src/protocol/handlers/list_groups.rs:
##########
@@ -0,0 +1,188 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! `ListGroups` (API key 16).
+//!
+//! Lists the groups this coordinator holds. v4+ `states_filter` and v5 
`types_filter` keep a
+//! group only when the filter is empty or one entry matches, 
case-insensitively, after trim.
+//! A filter value this coordinator does not use matches nothing, so the group 
is left out and
+//! the response error stays 0. Kafka 4.0's `listGroups` does the same ("if 
invalid, no groups
+//! are returned").
+
+use bytes::Bytes;
+use kafka_protocol::messages::list_groups_response::ListedGroup;
+use kafka_protocol::messages::{GroupId, ListGroupsRequest, ListGroupsResponse};
+use kafka_protocol::protocol::StrBytes;
+
+use crate::error::Result;
+use crate::group::GroupListing;
+use crate::protocol::api::{
+    API_KEY_LIST_GROUPS, ApiVersionRange, ERROR_INVALID_REQUEST, 
ERROR_UNSUPPORTED_VERSION,
+    GatewayState, HandleOutcome, is_supported_version,
+};
+use crate::protocol::bounds_guard::validate_list_groups_shape;
+use crate::protocol::handlers::{
+    decode_guarded, encode_message, respond_or_close, 
unsupported_version_response,
+};
+use crate::protocol::header::response_header_version;
+
+pub const RANGE: ApiVersionRange = ApiVersionRange {
+    api_key: API_KEY_LIST_GROUPS,
+    min_version: 0,
+    max_version: 5,
+};
+
+/// `ListGroups` v5 `group_type` for the classic protocol this coordinator 
runs.
+const CLASSIC_GROUP_TYPE: &str = "classic";
+
+pub async fn handle(state: &GatewayState, api_version: i16, body: Bytes) -> 
HandleOutcome {
+    if !is_supported_version(API_KEY_LIST_GROUPS, api_version) {
+        return unsupported_version_response(API_KEY_LIST_GROUPS, api_version, 
|version| {
+            encode_error_response(version, ERROR_UNSUPPORTED_VERSION)
+        });
+    }
+    let request = match decode_guarded::<ListGroupsRequest>(api_version, body, 
|version, body| {
+        validate_list_groups_shape(version, body, state.max_frame_size)
+    }) {
+        Ok(request) => request,
+        Err(error) => {
+            // debug!, not warn!: attacker-controlled, not operator-actionable.
+            tracing::debug!(%error, api_version, "Failed to decode ListGroups 
request");
+            return respond_or_close(
+                encode_error_response(api_version, ERROR_INVALID_REQUEST),
+                "ListGroups",
+            );
+        }
+    };
+
+    let listings: Vec<GroupListing> = state
+        .groups
+        .list_groups()
+        .await
+        .into_iter()
+        .filter(|group| {
+            selected(&request.states_filter, group.state)
+                && selected(&request.types_filter, CLASSIC_GROUP_TYPE)
+        })
+        .collect();
+    // `protocol_type` is echoed for every group. The shape guard never sees 
that list, so a
+    // coordinator holding many long types can still outgrow the frame. Price 
it before encode.
+    let encoded_bytes = list_response_frame_len(api_version, &listings);
+    if encoded_bytes > state.max_frame_size {

Review Comment:
   warning: `ListGroups` closes the connection when the listed groups exceed 
`max_frame_size`, but that size is server state, not a request the client 
chose. A peer can give about 256 groups a 32767-byte `protocol_type`, and every 
later unfiltered `ListGroups` then closes for every client. Truncate the 
listing to the frame budget, as `truncate_all_topics_to_frame_budget()` does in 
`metadata.rs`.



##########
gateways/kafka/src/protocol/handlers/describe_groups.rs:
##########
@@ -0,0 +1,160 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! `DescribeGroups` (API key 15).
+//!
+//! Reports the members, assignment and state of groups this coordinator 
holds. A named group
+//! that is not here is `Dead`: v6 also carries `GROUP_ID_NOT_FOUND`, and 
earlier versions do
+//! not, matching Kafka 4.0's `describeGroups`. A v6 client treats error 0 as 
a real group.
+//!
+//! `include_authorized_operations` is not answered. The field stays at the 
omitted sentinel
+//! (`i32::MIN`): there is no group ACL bitfield to report, and any other 
value fails the
+//! encoder below v3.
+
+use bytes::Bytes;
+use kafka_protocol::messages::describe_groups_response::{DescribedGroup, 
DescribedGroupMember};
+use kafka_protocol::messages::{DescribeGroupsRequest, DescribeGroupsResponse, 
GroupId};
+use kafka_protocol::protocol::StrBytes;
+
+use crate::error::Result;
+use crate::group::{DescribeGroupsView, GroupDescription, MemberDescription, 
distinct_group_ids};
+use crate::protocol::api::{
+    API_KEY_DESCRIBE_GROUPS, ApiVersionRange, ERROR_GROUP_ID_NOT_FOUND, 
ERROR_UNSUPPORTED_VERSION,
+    GatewayState, HandleOutcome, is_supported_version,
+};
+use crate::protocol::bounds_guard::validate_describe_groups_shape;
+use crate::protocol::handlers::{
+    decode_guarded, encode_message, respond_or_close, 
unsupported_version_response,
+};
+
+pub const RANGE: ApiVersionRange = ApiVersionRange {
+    api_key: API_KEY_DESCRIBE_GROUPS,
+    min_version: 0,
+    max_version: 6,
+};
+
+/// Kafka's `Dead` state. This coordinator never stores it: an absent group is 
reported as one.
+const DEAD: &str = "Dead";
+/// First version whose response has `error_message`, and the first on which 
Kafka 4.0 sends
+/// `GROUP_ID_NOT_FOUND` for a missing group.
+const FIRST_ERROR_MESSAGE_VERSION: i16 = 6;
+
+pub async fn handle(state: &GatewayState, api_version: i16, body: Bytes) -> 
HandleOutcome {
+    if !is_supported_version(API_KEY_DESCRIBE_GROUPS, api_version) {
+        return unsupported_version_response(API_KEY_DESCRIBE_GROUPS, 
api_version, |version| {
+            encode_error_response(version, ERROR_UNSUPPORTED_VERSION)
+        });
+    }
+    let request =
+        match decode_guarded::<DescribeGroupsRequest>(api_version, body, 
|version, body| {
+            validate_describe_groups_shape(version, body, state.max_frame_size)
+        }) {
+            Ok(request) => request,
+            Err(error) => {
+                // debug!, not warn!: attacker-controlled, not 
operator-actionable.
+                // The response has no top-level error field, and a failed 
decode yields no group
+                // id to hang `INVALID_REQUEST` on. An empty group list would 
look like success.
+                tracing::debug!(%error, api_version, "Failed to decode 
DescribeGroups request");
+                return HandleOutcome::Close;
+            }
+        };
+
+    let requested: Vec<StrBytes> = request
+        .groups
+        .iter()
+        .map(|group_id| group_id.0.clone())
+        .collect();
+    // One result per distinct id. Repeating one group would otherwise copy 
its members into the
+    // response once per copy, and the shape guard only charges the id strings.
+    let group_ids = distinct_group_ids(&requested);
+    match state
+        .groups
+        .describe_groups(&group_ids, api_version, state.max_frame_size)
+        .await
+    {
+        DescribeGroupsView::ExceedsFrame { encoded_bytes } => {
+            tracing::warn!(
+                encoded_bytes,
+                max_frame_size = state.max_frame_size,
+                "DescribeGroups response would exceed max_frame_size; closing 
connection"
+            );
+            HandleOutcome::Close
+        }
+        DescribeGroupsView::Groups(described) => {
+            let groups = group_ids
+                .iter()
+                .zip(described)
+                .map(|(group_id, group)| {
+                    group.map_or_else(|| missing_group(api_version, group_id), 
described_group)
+                })
+                .collect();
+            respond_or_close(encode_response(api_version, groups), 
"DescribeGroups")
+        }
+    }
+}
+
+fn described_group(group: GroupDescription) -> DescribedGroup {
+    DescribedGroup::default()
+        .with_group_id(GroupId(group.group_id))
+        .with_group_state(StrBytes::from_static_str(group.state))
+        .with_protocol_type(group.protocol_type)
+        .with_protocol_data(group.protocol_name.unwrap_or_default())
+        
.with_members(group.members.into_iter().map(described_member).collect())
+}
+
+fn described_member(member: MemberDescription) -> DescribedGroupMember {
+    // `client_id` and `client_host` stay empty: the coordinator does not 
retain the request
+    // header's client id, and handlers are not given the connection's peer 
address.
+    DescribedGroupMember::default()
+        .with_member_id(member.member_id)
+        .with_group_instance_id(member.group_instance_id)
+        .with_member_metadata(member.metadata)
+        .with_member_assignment(member.assignment)
+}
+
+fn missing_group(version: i16, group_id: &StrBytes) -> DescribedGroup {
+    let mut group = DescribedGroup::default()
+        .with_group_id(GroupId(group_id.clone()))
+        .with_group_state(StrBytes::from_static_str(DEAD));
+    if version >= FIRST_ERROR_MESSAGE_VERSION {
+        group = group
+            .with_error_code(ERROR_GROUP_ID_NOT_FOUND)
+            .with_error_message(Some(StrBytes::from_string(format!(
+                "Group {} not found.",
+                group_id.as_str()
+            ))));
+    }
+    group
+}
+
+/// # Errors
+///
+/// Returns an error when `kafka_protocol` cannot encode the response at 
`version`.
+pub fn encode_response(version: i16, groups: Vec<DescribedGroup>) -> 
Result<Bytes> {
+    let response = DescribeGroupsResponse::default().with_groups(groups);
+    encode_message(&response, version, 64)
+}
+
+/// # Errors
+///
+/// Returns an error when `kafka_protocol` cannot encode the response at 
`version`.
+pub fn encode_error_response(version: i16, _error_code: i16) -> Result<Bytes> {

Review Comment:
   simplification: `encode_error_response()` ignores `_error_code`, because 
`DescribeGroups` has no top-level error field to carry it. Call 
`encode_response(version, Vec::new())` at the call site and delete this wrapper 
along with the now-unused `ERROR_UNSUPPORTED_VERSION` import.



##########
gateways/kafka/src/protocol/handlers/list_groups.rs:
##########
@@ -0,0 +1,188 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! `ListGroups` (API key 16).
+//!
+//! Lists the groups this coordinator holds. v4+ `states_filter` and v5 
`types_filter` keep a
+//! group only when the filter is empty or one entry matches, 
case-insensitively, after trim.
+//! A filter value this coordinator does not use matches nothing, so the group 
is left out and
+//! the response error stays 0. Kafka 4.0's `listGroups` does the same ("if 
invalid, no groups
+//! are returned").
+
+use bytes::Bytes;
+use kafka_protocol::messages::list_groups_response::ListedGroup;
+use kafka_protocol::messages::{GroupId, ListGroupsRequest, ListGroupsResponse};
+use kafka_protocol::protocol::StrBytes;
+
+use crate::error::Result;
+use crate::group::GroupListing;
+use crate::protocol::api::{
+    API_KEY_LIST_GROUPS, ApiVersionRange, ERROR_INVALID_REQUEST, 
ERROR_UNSUPPORTED_VERSION,
+    GatewayState, HandleOutcome, is_supported_version,
+};
+use crate::protocol::bounds_guard::validate_list_groups_shape;
+use crate::protocol::handlers::{
+    decode_guarded, encode_message, respond_or_close, 
unsupported_version_response,
+};
+use crate::protocol::header::response_header_version;
+
+pub const RANGE: ApiVersionRange = ApiVersionRange {
+    api_key: API_KEY_LIST_GROUPS,
+    min_version: 0,
+    max_version: 5,
+};
+
+/// `ListGroups` v5 `group_type` for the classic protocol this coordinator 
runs.
+const CLASSIC_GROUP_TYPE: &str = "classic";
+
+pub async fn handle(state: &GatewayState, api_version: i16, body: Bytes) -> 
HandleOutcome {
+    if !is_supported_version(API_KEY_LIST_GROUPS, api_version) {
+        return unsupported_version_response(API_KEY_LIST_GROUPS, api_version, 
|version| {
+            encode_error_response(version, ERROR_UNSUPPORTED_VERSION)
+        });
+    }
+    let request = match decode_guarded::<ListGroupsRequest>(api_version, body, 
|version, body| {
+        validate_list_groups_shape(version, body, state.max_frame_size)
+    }) {
+        Ok(request) => request,
+        Err(error) => {
+            // debug!, not warn!: attacker-controlled, not operator-actionable.
+            tracing::debug!(%error, api_version, "Failed to decode ListGroups 
request");
+            return respond_or_close(
+                encode_error_response(api_version, ERROR_INVALID_REQUEST),
+                "ListGroups",
+            );
+        }
+    };
+
+    let listings: Vec<GroupListing> = state
+        .groups
+        .list_groups()
+        .await
+        .into_iter()
+        .filter(|group| {
+            selected(&request.states_filter, group.state)
+                && selected(&request.types_filter, CLASSIC_GROUP_TYPE)
+        })
+        .collect();
+    // `protocol_type` is echoed for every group. The shape guard never sees 
that list, so a
+    // coordinator holding many long types can still outgrow the frame. Price 
it before encode.
+    let encoded_bytes = list_response_frame_len(api_version, &listings);
+    if encoded_bytes > state.max_frame_size {
+        tracing::warn!(
+            encoded_bytes,
+            max_frame_size = state.max_frame_size,
+            "ListGroups response would exceed max_frame_size; closing 
connection"
+        );
+        return HandleOutcome::Close;
+    }
+    let groups = listings.into_iter().map(listed_group).collect();
+    respond_or_close(encode_response(api_version, groups), "ListGroups")
+}
+
+fn selected(filter: &[StrBytes], value: &str) -> bool {
+    filter.is_empty()
+        || filter
+            .iter()
+            .any(|wanted| wanted.as_str().trim().eq_ignore_ascii_case(value))
+}
+
+/// Header plus body, the length `send_response` writes and `read_frame` 
compares to
+/// `max_frame_size`.
+fn list_response_frame_len(version: i16, groups: &[GroupListing]) -> usize {
+    let flexible = version >= 3;
+    let mut total = if response_header_version(API_KEY_LIST_GROUPS, version) 
>= 1 {
+        5
+    } else {
+        4
+    };
+    if version >= 1 {
+        total += 4;
+    }
+    total += 2;
+    total += if flexible {
+        kafka_compact_prefix(groups.len())
+    } else {
+        4
+    };
+    for group in groups {
+        total = total.saturating_add(listed_group_len(version, group));
+    }
+    if flexible {
+        total += 1;
+    }
+    total
+}
+
+fn listed_group_len(version: i16, group: &GroupListing) -> usize {
+    let flexible = version >= 3;
+    let mut total = kafka_string_len(flexible, group.group_id.len());
+    total += kafka_string_len(flexible, group.protocol_type.len());
+    if version >= 4 {
+        total += kafka_string_len(true, group.state.len());
+    }
+    if version >= 5 {
+        total += kafka_string_len(true, CLASSIC_GROUP_TYPE.len());
+    }
+    if flexible {
+        total += 1;
+    }
+    total
+}
+
+fn kafka_compact_prefix(len: usize) -> usize {

Review Comment:
   simplification: `kafka_compact_prefix()` and `kafka_string_len()` duplicate 
`group/state.rs:1363-1376`, and both copies must stay identical to the 
encoder's arithmetic. Move them to one shared location and call it from this 
handler and the state pricing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to