ryerraguntla commented on code in PR #4401:
URL: https://github.com/apache/iggy/pull/4401#discussion_r4180755700
##########
gateways/kafka/src/group/mod.rs:
##########
@@ -451,6 +489,38 @@ impl GroupCoordinator {
state::leave_step(&mut groups, request, Instant::now())
}
+ /// Snapshot of each distinct group, in first-seen order. `None` means the
group is not here.
+ ///
+ /// Ids are deduped before the lock is taken. Under the lock each
remaining group is ticked
+ /// once and, when the encoded response fits `max_frame_size`, snapshotted
once. Encoding
+ /// happens after this returns. `ExceedsFrame` means the lengths already
stored would not
+ /// fit, and no member snapshot was built.
+ pub async fn describe_groups(
+ &self,
+ group_ids: &[StrBytes],
+ version: i16,
+ max_frame_size: usize,
+ ) -> DescribeGroupsView {
+ let group_ids = distinct_group_ids(group_ids);
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
