ryerraguntla commented on code in PR #4401:
URL: https://github.com/apache/iggy/pull/4401#discussion_r4202054879
##########
gateways/kafka/src/group/state.rs:
##########
@@ -708,6 +821,32 @@ fn join_request_error(config: &GroupCoordinatorConfig,
request: &JoinRequest) ->
None
}
+/// `protocol_type`, a client-supplied `member_id`, `group_instance_id`, and
each protocol
+/// `name` are echoed as legacy strings - the last of these by
`DescribeGroups` v0-v4, which
+/// writes the stored group's selected protocol name as `protocol_data` with
an i16 length, not
+/// by `JoinGroup` itself. When the member id is generated, the instance id is
the prefix and the
+/// `-{uuid}` suffix has to fit in the same cap.
+fn legacy_strings_too_long(request: &JoinRequest) -> bool {
+ if request.protocol_type.len() > MAX_LEGACY_STRING_BYTES
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
