hubcio commented on code in PR #4504:
URL: https://github.com/apache/iggy/pull/4504#discussion_r4257157187
##########
foreign/java/java-sdk/src/test/java/org/apache/iggy/client/blocking/tcp/IggyTcpClientBuilderTest.java:
##########
@@ -75,6 +76,18 @@ void shouldCreateClientWithCredentials() {
assertThat(clients).isNotNull();
}
+ @Test
+ void shouldCreateClientFromConnectionString() {
+ // Given: Builder configured from a connection string
+ IggyTcpClient client = Iggy.tcpClientBuilder()
Review Comment:
warning: the new integration test leaves its connected client and event loop
open after the test returns. close the local client in a `finally` block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
