mohitduhan19 commented on code in PR #4504:
URL: https://github.com/apache/iggy/pull/4504#discussion_r4257801535
##########
foreign/java/java-sdk/src/test/java/org/apache/iggy/client/blocking/tcp/IggyTcpClientBuilderTest.java:
##########
@@ -75,6 +76,18 @@ void shouldCreateClientWithCredentials() {
assertThat(clients).isNotNull();
}
+ @Test
+ void shouldCreateClientFromConnectionString() {
+ // Given: Builder configured from a connection string
+ IggyTcpClient client = Iggy.tcpClientBuilder()
Review Comment:
Thanks, fixed in 8859648. The test now opens the client in a
try-with-resources block, so `close()` always runs and shuts down the
connection and its event loop, even if the assertion fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
