mohitduhan19 commented on PR #4504:
URL: https://github.com/apache/iggy/pull/4504#issuecomment-6185710771
@mmodzelewski thanks, fixed all of them:
- `tls` and `tls_ca_file` are only applied when the string sets them, so
`enableTls().fromConnectionString("iggy://u:p@host:8090")` keeps TLS on.
`AsyncIggyTcpClientBuilderConnectionStringTest` covers the call order.
- `TcpConnectionString` is a final class with a private constructor now,
moved to `org.apache.iggy.config`, so the package cycle is gone. PR description
updated.
- `tls_ca_file` without `tls=true` is rejected, and so is a blank value.
- The blocking builder delegates to `asyncBuilder.fromConnectionString` and
only keeps username and password.
/ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
