Arham-Begani commented on code in PR #4552:
URL: https://github.com/apache/iggy/pull/4552#discussion_r4285141189
##########
foreign/node/src/client/client.ts:
##########
@@ -80,15 +91,77 @@ export class Client extends CommandAPI {
*/
constructor(config: ClientConfigOrString) {
const normalizedConfig = normalizeClientConfig(config);
- const { clientProvider, pool } =
+ const { clientProvider, pool, client } =
createPooledClientProvider(normalizedConfig);
super(clientProvider);
this._config = normalizedConfig;
this._pool = pool;
+ this.events = client;
+ }
+
+ /**
+ * Registers a listener for a connection lifecycle event.
+ *
+ * @param event - Event name
+ * @param listener - Called with the event's arguments
+ * @returns This client
+ */
+ on<E extends keyof ClientEventMap>(
Review Comment:
Kept this to Client as the issue asks, and documented the limit in the
README (b79775b). I can add them to SingleClient in a follow-up if you want
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
