Arham-Begani commented on PR #4552: URL: https://github.com/apache/iggy/pull/4552#issuecomment-6289850146
The rebase requested after #4561 is prepared locally against master `c5709f52042477d24c0847e6035bfdcafddc32bc`, at local head `61a41cdba34358f25439aa6994089218e847cc87`. It preserves the single-session replica routing, immediate cancellation, and removal of `_pool`; lifecycle listeners now follow all replica links. Shutdown waits for physical socket closure before one final `end`, and the wrapper awaits destruction. Local Node 24 validation: lint and build/protocol-mirror checks pass; all 13 focused lifecycle/wrapper/routing regressions pass. The complete unit run has 571 passes and two failures. The same two tests fail on untouched master on this Windows host (558 passes / two failures): the socket-accept timing assertion and the large partition-cache deadline test. This is **not ready**: `prek run` is blocked by Windows symlink permissions in the skill/license checks, and the real-server lifecycle check timed out without a local server. WSL cannot start because virtualization is disabled. Genuine contributor review/understanding of the adapted code is also pending. I have marked the PR draft while those requirements are addressed. The rebased commits have **not been pushed**: GitHub's head remains `b79775b32901fc548eb97aa52d0915b53beab852`, and its previous CI results do not validate the local rebase. The existing branch will be updated only after the remaining requirements are met, with its remote head checked and force-with-lease for the rewrite. No new PR will be opened. This status and the local rebase were prepared with OpenAI Codex assistance; no human-review attestation or passing real-server result is claimed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
