jun0315 commented on code in PR #5225:
URL: https://github.com/apache/inlong/pull/5225#discussion_r932854808
##########
inlong-tubemq/tubemq-server/src/main/java/org/apache/inlong/tubemq/server/master/web/MasterStatusCheckFilter.java:
##########
@@ -65,7 +69,10 @@ public void doFilter(ServletRequest request,
if (TStringUtils.isNotBlank(req.getQueryString())) {
sBuilder.append("?").append(req.getQueryString());
}
- resp.sendRedirect(sBuilder.toString());
+ this.redirectWhiteList = sBuilder.toString();
+ if (redirectWhiteList.equals(sBuilder.toString())) {
Review Comment:
Thanks for your review, In order to fix this warning, I saw the official
recommended good case, which needs to be compared with the white list, but I
didn't think of a better method.
warning:
https://user-images.githubusercontent.com/18047329/178671029-61bc4f9f-1e3b-4caa-90a5-6a8b3dab4092.png
codsql:
https://codeql.github.com/codeql-query-help/java/java-unvalidated-url-redirection/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
