vernedeng commented on code in PR #8463:
URL: https://github.com/apache/inlong/pull/8463#discussion_r1255321317
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/InlongTenantController.java:
##########
@@ -82,4 +83,13 @@ public Response<Boolean>
update(@Validated(UpdateByIdValidation.class) @RequestB
return Response.success(tenantService.update(request));
}
+ @RequestMapping(value = "/tenant/delete/{name}", method =
RequestMethod.GET)
+ @ApiOperation(value = "Delete inlong tenant by name")
+ @ApiImplicitParam(name = "name", dataTypeClass = String.class, required =
true)
+ @RequiresRoles(logical = Logical.OR, value = {INLONG_ADMIN,
INLONG_OPERATOR})
Review Comment:
INLONG_OPERATOR has no permission to do this.
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/InlongTenantRoleController.java:
##########
@@ -81,4 +81,11 @@ public Response<PageInfo<TenantRoleInfo>>
listByCondition(@RequestBody TenantRol
return Response.success(tenantRoleService.listByCondition(request));
}
+ @RequestMapping(value = "/role/tenant/delete/{id}", method =
RequestMethod.DELETE)
+ @ApiOperation(value = "Delete tenant role by ID")
+ @ApiImplicitParam(name = "id", dataTypeClass = Integer.class, required =
true)
+ @RequiresRoles(logical = Logical.OR, value = {UserRoleCode.TENANT_ADMIN,
UserRoleCode.TENANT_OPERATOR})
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
