healchow commented on code in PR #8463:
URL: https://github.com/apache/inlong/pull/8463#discussion_r1255573517
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/user/TenantRoleService.java:
##########
@@ -52,4 +52,11 @@ public interface TenantRoleService {
* Get one tenant role by name and tenant
*/
TenantRoleInfo getByUsernameAndTenant(String name, String tenant);
+
+ /**
+ * Delete tenant role by id
+ * @param id tenant role
+ * @return true = delete success/ false = delete fail
+ */
+ boolean delete(Integer id);
Review Comment:
Change the return type to `Boolean` please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
