fuweng11 commented on code in PR #8463:
URL: https://github.com/apache/inlong/pull/8463#discussion_r1255774930
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/tenant/InlongTenantServiceImpl.java:
##########
@@ -121,6 +122,14 @@ public Boolean update(InlongTenantRequest request) {
return true;
}
+ @Override
+ public Boolean delete(String name) {
Review Comment:
```suggestion
public Boolean delete(String name, String operator) {
```
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/tenant/InlongTenantServiceImpl.java:
##########
@@ -121,6 +122,14 @@ public Boolean update(InlongTenantRequest request) {
return true;
}
+ @Override
+ public Boolean delete(String name) {
+ InlongTenantEntity inlongTenantEntity =
inlongTenantEntityMapper.selectByName(name);
Review Comment:
Add some log. like `LOGGER.info("begin to delete inlong tenant name={} by
user={}", name, operator);`
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/tenant/InlongTenantServiceImpl.java:
##########
@@ -121,6 +122,14 @@ public Boolean update(InlongTenantRequest request) {
return true;
}
+ @Override
+ public Boolean delete(String name) {
+ InlongTenantEntity inlongTenantEntity =
inlongTenantEntityMapper.selectByName(name);
+ int success =
inlongTenantEntityMapper.deleteById(inlongTenantEntity.getId());
+ Preconditions.expectTrue(success == 1, "delete failed");
+ return true;
Review Comment:
Add some log. like LOGGER.info("success to delete inlong tenant name={} by
user={}", name, operator);
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/user/TenantRoleServiceImpl.java:
##########
@@ -126,4 +126,11 @@ public List<String> listTenantByUsername(String username) {
return tenantUserRoleEntityMapper.listByUsername(username);
}
+ @Override
+ public Boolean delete(Integer id) {
+ int success = tenantUserRoleEntityMapper.deleteById(id);
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
