EMsnap commented on code in PR #10440:
URL: https://github.com/apache/inlong/pull/10440#discussion_r1644066395
##########
inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/tubemq/src/main/java/org/apache/inlong/sort/tubemq/table/DynamicTubeMQTableDeserializationSchema.java:
##########
@@ -110,9 +110,15 @@ public void deserialize(Message message,
Collector<RowData> out) throws IOExcept
}
@Override
- public void flushAudit() {
+ public void flushAuditById(long checkpointId) {
if (sourceMetricData != null) {
- sourceMetricData.flushAuditData();
+ sourceMetricData.flushAuditById(checkpointId);
+ }
+ }
+ @Override
+ public void setNowCheckpointId(long checkpointId) {
+ if (sourceMetricData != null) {
+ sourceMetricData.setNowCheckpointId(checkpointId + 1);
Review Comment:
method name doesn't match the implementation, added id by 1 but the method
name is set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
