XiaoYou201 commented on code in PR #10440:
URL: https://github.com/apache/inlong/pull/10440#discussion_r1644400805
##########
inlong-sort/sort-flink/base/src/main/java/org/apache/inlong/sort/base/metric/MetricsCollector.java:
##########
@@ -31,11 +31,10 @@ public class MetricsCollector<T> implements
TimestampedCollector<T> {
private long timestampMillis;
- SourceMetricData metricData;
-
+ private final SourceMetricsReporter metricsReporter;
public MetricsCollector(Collector<T> collector,
- SourceMetricData sourceMetricData) {
- this.metricData = sourceMetricData;
+ SourceMetricsReporter sourceMetricData) {
Review Comment:
fix it， thx～
##########
inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/tubemq/src/main/java/org/apache/inlong/sort/tubemq/FlinkTubeMQConsumer.java:
##########
@@ -311,14 +324,21 @@ private Instant getRecords(Instant lastConsumeInstant,
List<Message> messageList
@Override
public void snapshotState(FunctionSnapshotContext context) throws
Exception {
-
+
deserializationSchema.setCurrentCheckpointId(context.getCheckpointId());
+ // Make sure snapshot all tube partitions' offset to avoid
inconsistency. See BUG-124774267 for details.
Review Comment:
fix it， thx～
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
