EMsnap commented on code in PR #10440: URL: https://github.com/apache/inlong/pull/10440#discussion_r1644354061
########## inlong-sort/sort-flink/base/src/main/java/org/apache/inlong/sort/base/metric/SourceExactlyMetric.java: ########## @@ -0,0 +1,330 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.sort.base.metric; + +import org.apache.inlong.audit.AuditReporterImpl; + +import org.apache.flink.metrics.Counter; +import org.apache.flink.metrics.Gauge; +import org.apache.flink.metrics.Meter; +import org.apache.flink.metrics.MetricGroup; +import org.apache.flink.metrics.SimpleCounter; + +import java.io.Serializable; +import java.util.List; +import java.util.Map; + +import static org.apache.inlong.audit.consts.ConfigConstants.DEFAULT_AUDIT_TAG; +import static org.apache.inlong.common.constant.Constants.DEFAULT_AUDIT_VERSION; +import static org.apache.inlong.sort.base.Constants.CURRENT_EMIT_EVENT_TIME_LAG; +import static org.apache.inlong.sort.base.Constants.CURRENT_FETCH_EVENT_TIME_LAG; +import static org.apache.inlong.sort.base.Constants.NUM_BYTES_IN; +import static org.apache.inlong.sort.base.Constants.NUM_BYTES_IN_FOR_METER; +import static org.apache.inlong.sort.base.Constants.NUM_BYTES_IN_PER_SECOND; +import static org.apache.inlong.sort.base.Constants.NUM_RECORDS_IN; +import static org.apache.inlong.sort.base.Constants.NUM_RECORDS_IN_FOR_METER; +import static org.apache.inlong.sort.base.Constants.NUM_RECORDS_IN_PER_SECOND; +import static org.apache.inlong.sort.base.util.CalculateObjectSizeUtils.getDataSize; + +public class SourceExactlyMetric implements MetricData, Serializable, SourceMetricsReporter { Review Comment: some of the methods are exactly the same as in sourceMetricData, please extract a base class or abstract class ########## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/tubemq/src/main/java/org/apache/inlong/sort/tubemq/FlinkTubeMQConsumer.java: ########## @@ -311,14 +324,21 @@ private Instant getRecords(Instant lastConsumeInstant, List<Message> messageList @Override public void snapshotState(FunctionSnapshotContext context) throws Exception { - + deserializationSchema.setCurrentCheckpointId(context.getCheckpointId()); + // Make sure snapshot all tube partitions' offset to avoid inconsistency. See BUG-124774267 for details. Review Comment: what is BUG-124774267 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
