tiagodolphine commented on code in PR #1925:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/1925#discussion_r1415687212
##########
jobs-service/jobs-service-common/src/main/java/org/kie/kogito/jobs/service/json/JacksonConfiguration.java:
##########
@@ -41,8 +45,16 @@ public class JacksonConfiguration {
public ObjectMapperCustomizer customizer() {
return objectMapper -> {
LOGGER.debug("Jackson customization initialized.");
+ SimpleModule kogitoCustomModule = new SimpleModule();
+
kogitoCustomModule.addSerializer(ProcessInstanceJobDescription.class, new
ProcessInstanceJobDescriptionSerializer());
+
kogitoCustomModule.addDeserializer(ProcessInstanceJobDescription.class, new
ProcessInstanceJobDescriptionDeserializer());
+ kogitoCustomModule.addSerializer(DurationExpirationTime.class, new
DurationExpirationTimeSerializer());
+ kogitoCustomModule.addDeserializer(DurationExpirationTime.class,
new DurationExpirationTimeDeserializer());
+ kogitoCustomModule.addSerializer(ExactExpirationTime.class, new
ExactExpirationTimeSerializer());
+ kogitoCustomModule.addDeserializer(ExactExpirationTime.class, new
ExactExpirationTimeDeserializer());
Review Comment:
The serializers related to `kogito-api` could be moved to the new addon for
the collocated jobs-service, with an additional objectMapper customizer, this
seems specific to the addon, and this way we keep the core of jobs-service as
decoupled as possible from the runtimes internal APIs, wdyt?
c/c @wmedvede
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
