pefernan commented on code in PR #1925:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/1925#discussion_r1440306080
##########
jobs-service/jobs-service-common/src/main/java/org/kie/kogito/jobs/service/job/DelegateJob.java:
##########
@@ -40,9 +40,9 @@ public class DelegateJob implements Job<JobDetailsContext> {
private final JobExecutorResolver jobExecutorResolver;
- private final JobStreams jobStreams;
+ private final JobEventPublisher jobStreams;
- public DelegateJob(JobExecutorResolver executorResolver, JobStreams
jobStreams) {
+ public DelegateJob(JobExecutorResolver executorResolver, JobEventPublisher
jobStreams) {
Review Comment:
same here
##########
jobs-service/jobs-service-common/src/main/java/org/kie/kogito/jobs/service/job/DelegateJob.java:
##########
@@ -40,9 +40,9 @@ public class DelegateJob implements Job<JobDetailsContext> {
private final JobExecutorResolver jobExecutorResolver;
- private final JobStreams jobStreams;
+ private final JobEventPublisher jobStreams;
Review Comment:
I'd rename `jobStreams` to `jobEventPublisher`
##########
jobs-service/jobs-service-common/src/main/java/org/kie/kogito/jobs/service/repository/impl/BaseReactiveJobRepository.java:
##########
@@ -30,17 +30,17 @@
import org.kie.kogito.jobs.service.model.JobDetails;
import org.kie.kogito.jobs.service.model.JobStatus;
import org.kie.kogito.jobs.service.repository.ReactiveJobRepository;
-import org.kie.kogito.jobs.service.stream.JobStreams;
+import org.kie.kogito.jobs.service.stream.JobEventPublisher;
import io.vertx.core.Vertx;
public abstract class BaseReactiveJobRepository implements
ReactiveJobRepository {
private Vertx vertx;
- private JobStreams jobStreams;
+ private JobEventPublisher jobStreams;
- protected BaseReactiveJobRepository(Vertx vertx, JobStreams jobStreams) {
+ protected BaseReactiveJobRepository(Vertx vertx, JobEventPublisher
jobStreams) {
Review Comment:
same
##########
jobs-service/jobs-service-common/src/main/java/org/kie/kogito/jobs/service/scheduler/impl/TimerDelegateJobScheduler.java:
##########
@@ -58,7 +52,7 @@ public class TimerDelegateJobScheduler extends
BaseTimerJobScheduler {
private VertxTimerServiceScheduler delegate;
- private JobStreams jobStreams;
+ private JobEventPublisher jobStreams;
Review Comment:
same
##########
jobs-service/jobs-service-common/src/main/java/org/kie/kogito/jobs/service/repository/impl/InMemoryJobRepository.java:
##########
@@ -53,7 +53,7 @@ public InMemoryJobRepository() {
}
@Inject
- public InMemoryJobRepository(Vertx vertx, JobStreams jobStreams) {
+ public InMemoryJobRepository(Vertx vertx, JobEventPublisher jobStreams) {
Review Comment:
same
##########
jobs-service/jobs-service-infinispan/src/main/java/org/kie/kogito/jobs/service/repository/infinispan/InfinispanJobRepository.java:
##########
@@ -58,7 +58,7 @@ public class InfinispanJobRepository extends
BaseReactiveJobRepository implement
@Inject
public InfinispanJobRepository(Vertx vertx,
- JobStreams jobStreams,
+ JobEventPublisher jobStreams,
Review Comment:
same
##########
jobs-service/jobs-service-common/src/main/java/org/kie/kogito/jobs/service/scheduler/impl/TimerDelegateJobScheduler.java:
##########
@@ -70,7 +64,7 @@ public TimerDelegateJobScheduler(ReactiveJobRepository
jobRepository,
@ConfigProperty(name =
"kogito.jobs-service.schedulerChunkInMinutes", defaultValue = "10") long
schedulerChunkInMinutes,
@ConfigProperty(name =
"kogito.jobs-service.forceExecuteExpiredJobs", defaultValue = "true") boolean
forceExecuteExpiredJobs,
JobExecutorResolver jobExecutorResolver,
VertxTimerServiceScheduler delegate,
- JobStreams jobStreams) {
+ JobEventPublisher jobStreams) {
Review Comment:
same
##########
data-index/kogito-addons-quarkus-data-index-persistence/kogito-addons-quarkus-data-index-persistence-common/runtime/.gitignore:
##########
@@ -0,0 +1 @@
+/target/
Review Comment:
I'd remove this file
##########
jobs-service/jobs-service-common/src/test/java/org/kie/kogito/jobs/service/scheduler/impl/VertxTimerServiceSchedulerTest.java:
##########
@@ -62,7 +62,7 @@ class VertxTimerServiceSchedulerTest {
private JobExecutorResolver jobExecutorResolver;
@Mock
- private JobStreams jobStreams;
+ private JobEventPublisher jobStreams;
Review Comment:
same
##########
jobs-service/jobs-service-postgresql-common/src/main/java/org/kie/kogito/jobs/service/repository/postgresql/PostgreSqlJobRepository.java:
##########
@@ -74,7 +74,7 @@ public class PostgreSqlJobRepository extends
BaseReactiveJobRepository implement
}
@Inject
- public PostgreSqlJobRepository(Vertx vertx, JobStreams jobStreams, PgPool
client,
+ public PostgreSqlJobRepository(Vertx vertx, JobEventPublisher jobStreams,
PgPool client,
Review Comment:
same
##########
jobs-service/jobs-service-common/src/main/java/org/kie/kogito/jobs/service/repository/impl/BaseReactiveJobRepository.java:
##########
@@ -30,17 +30,17 @@
import org.kie.kogito.jobs.service.model.JobDetails;
import org.kie.kogito.jobs.service.model.JobStatus;
import org.kie.kogito.jobs.service.repository.ReactiveJobRepository;
-import org.kie.kogito.jobs.service.stream.JobStreams;
+import org.kie.kogito.jobs.service.stream.JobEventPublisher;
import io.vertx.core.Vertx;
public abstract class BaseReactiveJobRepository implements
ReactiveJobRepository {
private Vertx vertx;
- private JobStreams jobStreams;
+ private JobEventPublisher jobStreams;
Review Comment:
same
##########
data-index/kogito-addons-quarkus-data-index/kogito-addons-quarkus-data-index-common/runtime/.gitignore:
##########
@@ -0,0 +1 @@
+/target/
Review Comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
