elguardian commented on code in PR #1925:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/1925#discussion_r1422057409
##########
jobs-service/jobs-service-common/src/main/java/org/kie/kogito/jobs/service/json/JacksonConfiguration.java:
##########
@@ -41,8 +45,16 @@ public class JacksonConfiguration {
public ObjectMapperCustomizer customizer() {
return objectMapper -> {
LOGGER.debug("Jackson customization initialized.");
+ SimpleModule kogitoCustomModule = new SimpleModule();
+
kogitoCustomModule.addSerializer(ProcessInstanceJobDescription.class, new
ProcessInstanceJobDescriptionSerializer());
+
kogitoCustomModule.addDeserializer(ProcessInstanceJobDescription.class, new
ProcessInstanceJobDescriptionDeserializer());
+ kogitoCustomModule.addSerializer(DurationExpirationTime.class, new
DurationExpirationTimeSerializer());
+ kogitoCustomModule.addDeserializer(DurationExpirationTime.class,
new DurationExpirationTimeDeserializer());
+ kogitoCustomModule.addSerializer(ExactExpirationTime.class, new
ExactExpirationTimeSerializer());
+ kogitoCustomModule.addDeserializer(ExactExpirationTime.class, new
ExactExpirationTimeDeserializer());
Review Comment:
there are many things in kogito api or kogito events api that, honestly job,
user task and workflow engine should be in the same kogito-events-api or core
as they are mandatory elements of the workflow engine (it cannot function
without them). This is only used in the addon as for some reason the data being
passes through kafka seems to be duplicated or changed depending on the end
using it (client/server)
I would go for this in first place and the discuss how to rearrange things
after the user task app. (it will happen at some point after 9.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
