tiagobento commented on code in PR #2075:
URL:
https://github.com/apache/incubator-kie-tools/pull/2075#discussion_r1422827670
##########
packages/scesim-editor/package.json:
##########
@@ -15,12 +15,17 @@
"dependencies": {
"@kie-tools-core/i18n": "workspace:*",
"@kie-tools-core/patternfly-base": "workspace:*",
+ "@kie-tools/boxed-expression-component": "workspace:*",
"@kie-tools/i18n-common-dictionary": "workspace:*",
"@patternfly/react-core": "^4.276.6",
"@patternfly/react-icons": "^4.93.6",
"@patternfly/react-styles": "^4.92.6",
+ "@patternfly/react-table": "^4.112.39",
Review Comment:
Why do we need this? I think I removed this dependency as part of the BEE
refactoring that was done in the beginning of this year..
##########
packages/boxed-expression-component/src/api/BeeTable.ts:
##########
@@ -77,7 +77,7 @@ export interface BeeTableProps<R extends object> {
onRowDuplicated?: (args: { rowIndex: number }) => void;
onRowReset?: (args: { rowIndex: number }) => void;
onRowDeleted?: (args: { rowIndex: number }) => void;
- onColumnAdded?: (args: { beforeIndex: number; groupType: string | undefined
}) => void;
+ onColumnAdded?: (args: { beforeIndex: number; currentIndex?: number;
groupType: string | undefined }) => void;
Review Comment:
Why do we need `currentIndex` for the SceSim table use-case?
##########
packages/scesim-editor/package.json:
##########
@@ -31,11 +36,13 @@
"@kie-tools/root-env": "workspace:*",
"@kie-tools/scesim-marshaller": "workspace:*",
"@kie-tools/tsconfig": "workspace:*",
+ "@types/lodash": "^4.14.168",
"@types/react": "^17.0.6",
"@types/react-dom": "^17.0.5",
+ "@types/react-table": "^7.0.25",
Review Comment:
Same for this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
