yesamer commented on code in PR #2075:
URL:
https://github.com/apache/incubator-kie-tools/pull/2075#discussion_r1423086620
##########
packages/scesim-editor/package.json:
##########
@@ -31,11 +36,13 @@
"@kie-tools/root-env": "workspace:*",
"@kie-tools/scesim-marshaller": "workspace:*",
"@kie-tools/tsconfig": "workspace:*",
+ "@types/lodash": "^4.14.168",
"@types/react": "^17.0.6",
"@types/react-dom": "^17.0.5",
+ "@types/react-table": "^7.0.25",
Review Comment:
```
packages/scesim-editor build:dev$ rimraf dist && tsc -p tsconfig.json
│ src/@types/react-tables.ts(23,16): error TS2665: Invalid module name in
augmentation. Module 'react-table' resolves to an untyped module at '/Us…
│ src/@types/react-tables.ts(65,21): error TS2304: Cannot find name 'Column'.
│ src/@types/react-tables.ts(65,21): error TS4033: Property 'columns' of
exported interface has or is using private name 'Column'.
│ src/table/TestScenarioTable.tsx(23,29): error TS7016: Could not find a
declaration file for module 'react-table'. '/Users/yamer/Projects/kie-too…
│ If the 'react-table' package actually exposes this module, consider
sending a pull request to amend 'https://github.com/DefinitelyTyped/Defini…
│ src/table/TestScenarioTable.tsx(328,28): error TS2339: Property
'groupType' does not exist on type 'ColumnInstance<any>'.
│ src/table/TestScenarioTable.tsx(329,28): error TS2339: Property
'groupType' does not exist on type 'ColumnInstance<any>'.
│ src/table/TestScenarioTable.tsx(331,28): error TS2339: Property
'groupType' does not exist on type 'ColumnInstance<any>'.
│ src/table/TestScenarioTable.tsx(332,28): error TS2339: Property
'groupType' does not exist on type 'ColumnInstance<any>'.
│ src/table/TestScenarioTable.tsx(339,44): error TS2339: Property
'groupType' does not exist on type 'ColumnInstance<any>'.
│ src/table/TestScenarioTable.tsx(342,61): error TS2339: Property
'groupType' does not exist on type 'ColumnInstance<any>'.
└─ Failed in 3.4s at /Users/yamer/Projects/kie-tools/packages/scesim-editor
```
##########
packages/scesim-editor/package.json:
##########
@@ -31,11 +36,13 @@
"@kie-tools/root-env": "workspace:*",
"@kie-tools/scesim-marshaller": "workspace:*",
"@kie-tools/tsconfig": "workspace:*",
+ "@types/lodash": "^4.14.168",
"@types/react": "^17.0.6",
"@types/react-dom": "^17.0.5",
+ "@types/react-table": "^7.0.25",
Review Comment:
```
packages/scesim-editor build:dev$ rimraf dist && tsc -p tsconfig.json
│ src/@types/react-tables.ts(23,16): error TS2665: Invalid module name in
augmentation. Module 'react-table' resolves to an untyped module at '/Us…
│ src/@types/react-tables.ts(65,21): error TS2304: Cannot find name 'Column'.
│ src/@types/react-tables.ts(65,21): error TS4033: Property 'columns' of
exported interface has or is using private name 'Column'.
│ src/table/TestScenarioTable.tsx(23,29): error TS7016: Could not find a
declaration file for module 'react-table'. '/Users/yamer/Projects/kie-too…
│ If the 'react-table' package actually exposes this module, consider
sending a pull request to amend 'https://github.com/DefinitelyTyped/Defini…
│ src/table/TestScenarioTable.tsx(328,28): error TS2339: Property
'groupType' does not exist on type 'ColumnInstance<any>'.
│ src/table/TestScenarioTable.tsx(329,28): error TS2339: Property
'groupType' does not exist on type 'ColumnInstance<any>'.
│ src/table/TestScenarioTable.tsx(331,28): error TS2339: Property
'groupType' does not exist on type 'ColumnInstance<any>'.
│ src/table/TestScenarioTable.tsx(332,28): error TS2339: Property
'groupType' does not exist on type 'ColumnInstance<any>'.
│ src/table/TestScenarioTable.tsx(339,44): error TS2339: Property
'groupType' does not exist on type 'ColumnInstance<any>'.
│ src/table/TestScenarioTable.tsx(342,61): error TS2339: Property
'groupType' does not exist on type 'ColumnInstance<any>'.
└─ Failed in 3.4s at /Users/yamer/Projects/kie-tools/packages/scesim-editor
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
