tiagobento commented on code in PR #2075:
URL:
https://github.com/apache/incubator-kie-tools/pull/2075#discussion_r1423172353
##########
packages/boxed-expression-component/src/api/BeeTable.ts:
##########
@@ -77,7 +77,7 @@ export interface BeeTableProps<R extends object> {
onRowDuplicated?: (args: { rowIndex: number }) => void;
onRowReset?: (args: { rowIndex: number }) => void;
onRowDeleted?: (args: { rowIndex: number }) => void;
- onColumnAdded?: (args: { beforeIndex: number; groupType: string | undefined
}) => void;
+ onColumnAdded?: (args: { beforeIndex: number; currentIndex?: number;
groupType: string | undefined }) => void;
Review Comment:
Well, we have this exact same capability on the Boxed Expression Editor, and
we didn't need the `currentIndex` property. I guess it's just a matter of where
we are resolving this logic. Can you please check other components to see how
they solved it? And if you still find that your use-case is different and the
`currentIndex` is required, I guess we can reassess keeping this new property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
