baldimir commented on code in PR #5620:
URL:
https://github.com/apache/incubator-kie-drools/pull/5620#discussion_r1423603836
##########
kie-memory-compiler/src/main/java/org/kie/memorycompiler/jdknative/NativeJavaCompiler.java:
##########
@@ -87,7 +87,7 @@ public CompilationResult compile( String[] pResourcePaths,
DiagnosticCollector<JavaFileObject> diagnostics = new
DiagnosticCollector<>();
JavaCompiler compiler = getJavaCompiler();
- try (StandardJavaFileManager jFileManager =
compiler.getStandardFileManager(diagnostics, null, null)) {
+ try (StandardJavaFileManager jFileManager =
compiler.getStandardFileManager(diagnostics, null,
Charset.forName(pSettings.getSourceEncoding()))) {
Review Comment:
UTF-8 is used by default in the configuration, so I wanted to promote its
use as it is used also elsewhere. I plan a larger review of encoding next year,
I would say we could solve this problem in a more global better way then (maybe
having some drools.encoding property or similar). What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
