gitgabrio commented on code in PR #5620:
URL:
https://github.com/apache/incubator-kie-drools/pull/5620#discussion_r1423660112
##########
kie-memory-compiler/src/main/java/org/kie/memorycompiler/jdknative/NativeJavaCompiler.java:
##########
@@ -87,7 +87,7 @@ public CompilationResult compile( String[] pResourcePaths,
DiagnosticCollector<JavaFileObject> diagnostics = new
DiagnosticCollector<>();
JavaCompiler compiler = getJavaCompiler();
- try (StandardJavaFileManager jFileManager =
compiler.getStandardFileManager(diagnostics, null, null)) {
+ try (StandardJavaFileManager jFileManager =
compiler.getStandardFileManager(diagnostics, null,
Charset.forName(pSettings.getSourceEncoding()))) {
Review Comment:
Fine for me!
Side note: is there any test/pr check with different encoding ? If not, I
think, in the future, we should try to also have this kind of checkl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
