baldimir commented on code in PR #5620:
URL:
https://github.com/apache/incubator-kie-drools/pull/5620#discussion_r1423706272
##########
kie-memory-compiler/src/main/java/org/kie/memorycompiler/jdknative/NativeJavaCompiler.java:
##########
@@ -87,7 +87,7 @@ public CompilationResult compile( String[] pResourcePaths,
DiagnosticCollector<JavaFileObject> diagnostics = new
DiagnosticCollector<>();
JavaCompiler compiler = getJavaCompiler();
- try (StandardJavaFileManager jFileManager =
compiler.getStandardFileManager(diagnostics, null, null)) {
+ try (StandardJavaFileManager jFileManager =
compiler.getStandardFileManager(diagnostics, null,
Charset.forName(pSettings.getSourceEncoding()))) {
Review Comment:
There are some tests, as far as I know, that use a resource in different
encoding. However this fix is for a case where the environment is in different
encoding. That is why I was not able to add any new test case unfortunately. If
someone knows how we could simulate that reliably, please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
