tiagobento commented on code in PR #2075:
URL:
https://github.com/apache/incubator-kie-tools/pull/2075#discussion_r1424445760
##########
packages/boxed-expression-component/src/api/BeeTable.ts:
##########
@@ -77,7 +77,7 @@ export interface BeeTableProps<R extends object> {
onRowDuplicated?: (args: { rowIndex: number }) => void;
onRowReset?: (args: { rowIndex: number }) => void;
onRowDeleted?: (args: { rowIndex: number }) => void;
- onColumnAdded?: (args: { beforeIndex: number; groupType: string | undefined
}) => void;
+ onColumnAdded?: (args: { beforeIndex: number; currentIndex?: number;
groupType: string | undefined }) => void;
Review Comment:
Ok, got it! Yeah, the BeeTable is only prepared to differentiate between
columns that are in different groups.
On a different perspective...... should we really have the capability of
manually adding/removing columns from a SceSim file? I don't know if we talked
about this already, but I feel like we should only allow users to select
columns from known properties that come from the DMN itself... I mean, manually
keeping the SceSim file in sync with the DMN might be very tedious and error
prone, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
