jordigilh commented on PR #311: URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/311#issuecomment-1856395504
> Hello Guys @jordigilh @tchughesiv @ricardozanini , I'll add some test results here. (the last commits added by @jordigilh were used) > > **Note:** In general I have added reproducers for the tests cases here: https://github.com/wmedvede/techpreview2/tree/test-platform-services, feel to clone and give it a try locally > > **Case 1:** We deploy the platform with jobs service + postgresql persistence (no workflows): > > **reproducer here:** https://github.com/wmedvede/techpreview2/blob/1a2cc37f4f9a9c1423db873da847ee409a576e4d/platforms/jobservice_as_platform_service_postgresql/Readme.txt > > What we can see is that the jobs service tries to start, but, no reactive url is created, and thus it fails. These are the options in my opinion: > > **Option 1)** we don't let it start, since we have no workflows yet. > > **Option 2)** we let it start, in that case, we need the reactive datasource URL I think we have discussed already in favor of option 2. > >  > > These are the generated properties: > >  There are 2 issues I noticed in the logs: * The controller keeps dumping this error due to a schema validation in the persistence struct for postgreSQL: https://github.com/apache/incubator-kie-kogito-serverless-operator/blob/3b5108ca8c352cb3d81fd736f3e116ed21e66a3f/api/v1alpha08/sonataflowplatform_services_types.go#L47C4-L48 ``` E1214 16:50:41.630051 1 defaults.go:79] "Error updating the BuildPlatform" err="SonataFlowPlatform.sonataflow.org \"sonataflow-platform\" is invalid: spec.services.jobService.persistence.postgresql: Too many: 3: must have at most 2 items" ``` It's fixed by increasing the `maxProperty` value to 3. @tchughesiv do you know why it was limited to 2 max in the first place? Any reason for the validation? Can it be increased to 3? * The job service app properties are not added because the code that adds these properties is never called. The code is executed only when the a sonataflow CR is created, but not when the service is created. In this case should it add the same properties to the configmap as it does for a sonataflow CR? Or should it be a subset of those (reactiveURL and something else?). @wmedvede please advise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
