jordigilh commented on PR #311: URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/311#issuecomment-1858106400
> > > ``` > > > 1. When deploying Jobs Service or Data Index, the `SonataFlowPlatform` controller must set the config properties for each service accordingly for them to work independently. > > > 2. During the `SonataFlow` controller reconciliation, if the workflow is not `dev` and if there's a `SonataFlowPlatform` with Jobs Service and DI available in the current context, it should have the workflow application properties being updated to add the required properties for the workflow to connect and send events to those services. > > > ``` > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > That's the use case. > > > > > > Should the properties in each service be any different for the service itself or for the deployment triggered by a sonataflow CR instance? In other words: the properties specific for creating the job service are all included in the properties for a sonataflow CR? or a subset of those? > > Right now I consider them to be the same. > > @jordigilh service properties will be different than workflow properties. sure, they may share a few similar configs but there will be configs that only services use... and configs that only the workflows will use. you should be able to reference what was already done w/ DI vs the workflow properties.. and then modify to fit the needs of job service. e.g. the `NewServiceAppPropertyHandler`. I'm interested in which properties are specific to the service deployment, which ones are shared between workflows and service deployment and which ones are specific to the workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
