ricardozanini commented on PR #311:
URL: 
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/311#issuecomment-1858106123

   Hi @jordigilh 
   
   > in other words: the properties specific for creating the job service are 
all included in the properties for a sonataflow CR? or a subset of those?
   
   > Right now I consider them to be the same.
   
   No, they are not the same. I think it was there that things messed a little 
bit. Take a look at this repo we shared at the beginning of the development:
   
   
https://github.com/flows-examples/techpreview2/tree/main/infra/dataindex_and_jobservice
   
   You can see the JS Deployment and the `application.properties` for it there. 
That's exactly what we were expecting for this PR to do.
   
   And then, if you see the use case:
   
https://github.com/flows-examples/techpreview2/tree/main?tab=readme-ov-file#use-case-3
   
   It's explained there how it is supposed to be working. The workflow has yet 
another set of properties:
   
https://github.com/flows-examples/techpreview2/blob/main/workflows/sonataflow-callbackstatetimeouts-persistence/02-configmap_callbackstatetimeouts-props
   
   That's why I asked to separate the props in the first place last week 
between the services and the workflow. I thought it was clear since these use 
cases were already working and defined in that repo. I'm sorry if I made an 
incorrect assumption.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to