tchughesiv commented on PR #311: URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/311#issuecomment-1860441339
> So your concern is valid, but we will have a problem deploying the jobs-service before getting there since the deployment name will already be taken. So we need to fix the naming clash while creating these objects. @ricardozanini this is not an issue. objects can be identically named, as long as their `kind` is different. this already works for DI in the main branch and will work just as well for JS. this is actually ideal as the user has better understanding of which objects are interconnected. it's easier for operator to maintain as well. that said, my concern is still valid, but for a different reason. we should only use something that will resolve "locally" to the container itself. e.g. localhost, 127.0.0.1, etc. Just because the operator hasn't created a `job-service` service, this doesn't mean a user hasn't done so manually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
