ricardozanini commented on code in PR #337:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/337#discussion_r1436433387
##########
test/e2e/workflow_test.go:
##########
@@ -253,26 +257,173 @@ var _ = Describe("SonataFlow Operator", Ordered, func() {
}, time.Minute, time.Second).Should(Succeed())
})
})
+
+ const (
+ ephemeral = "ephemeral"
+ postgreSQL = "postgreSQL"
+ dev = "dev"
+ production = "production"
Review Comment:
Can you use the typed var instead?
https://github.com/apache/incubator-kie-kogito-serverless-operator/blob/main/api/metadata/annotations.go#L49-L50
We will eventually rename it.
##########
test/testdata/data-index_and_job-service/dev/postgreSQL/01-postgres.yaml:
##########
@@ -0,0 +1,72 @@
+---
+apiVersion: v1
Review Comment:
Can't we reuse this same postgres manifest?
##########
controllers/platform/services/services.go:
##########
@@ -114,8 +114,8 @@ func (d DataIndex) GetEnvironmentVariables()
[]corev1.EnvVar {
func (d DataIndex) GetPodResourceRequirements() corev1.ResourceRequirements {
return corev1.ResourceRequirements{
Limits: corev1.ResourceList{
- corev1.ResourceCPU: resource.MustParse("100m"),
- corev1.ResourceMemory: resource.MustParse("256Mi"),
+ corev1.ResourceCPU: resource.MustParse("500m"),
+ corev1.ResourceMemory: resource.MustParse("1Gi"),
},
Review Comment:
Is there any justification for this change? Have you run a benchmark?
@wmedvede do you have any idea regarding DI/JS consumption resources? Can we
have a follow-up task to get a more approximated number? I feel like this can
be too much for a default setup. Mainly when running it locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
