jordigilh commented on code in PR #337:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/337#discussion_r1437119446
##########
test/e2e/workflow_test.go:
##########
@@ -253,26 +257,173 @@ var _ = Describe("SonataFlow Operator", Ordered, func() {
}, time.Minute, time.Second).Should(Succeed())
})
})
+
+ const (
+ ephemeral = "ephemeral"
+ postgreSQL = "postgreSQL"
+ dev = "dev"
+ production = "production"
Review Comment:
These constants meant to define the directory structure of the test data and
to be independent from the profile constants.
I'm concerned that if I use the annotations for this, eventual changes to
their values will lead to problems as the values are hardcoded to the directory
structure, rather than values in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
