masayag commented on code in PR #341:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/341#discussion_r1445271860
##########
controllers/platform/k8s.go:
##########
@@ -196,7 +196,7 @@ func createDeployment(ctx context.Context, client
client.Client, platform *opera
func createService(ctx context.Context, client client.Client, platform
*operatorapi.SonataFlowPlatform, ps services.Platform) error {
lbl := map[string]string{
- workflowproj.LabelApp: platform.Name,
+ workflowproj.LabelApp: ps.GetServiceName(),
Review Comment:
Should we maintain the same label for both services?
By looking at the
[previous](https://github.com/flows-examples/techpreview2/blob/main/infra/dataindex/02-dataindex.yaml#L11)
deployment of data-index, the label was `app.kubernetes.io/name:
data-index-service-postgresql`
The
[label](https://github.com/flows-examples/techpreview2/blob/main/infra/dataindex_and_jobservice/03-jobservice.yml#L14)
for the job-service was `app.kubernetes.io/name: jobs-service-postgresql`
If we wish to maintain a relationship between the services and the platform,
ownerReference seems a better representation of the relations between them.
Raised my concern, but will act based on your decision here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
