tchughesiv commented on code in PR #341:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/341#discussion_r1445286725
##########
controllers/platform/k8s.go:
##########
@@ -196,7 +196,7 @@ func createDeployment(ctx context.Context, client
client.Client, platform *opera
func createService(ctx context.Context, client client.Client, platform
*operatorapi.SonataFlowPlatform, ps services.Platform) error {
lbl := map[string]string{
- workflowproj.LabelApp: platform.Name,
+ workflowproj.LabelApp: ps.GetServiceName(),
Review Comment:
that may be the case for the tech preview templates, but the operator
doesn't set that label. it sets `app: <platform.name>`. i'm suggesting we leave
that label as-is and add a new service-specific label...
maybe`sonataflow.org/service`?
so the labels would look like this for the related service objects -
`sonataflowplatform.name = test`
data index objects
```
labels:
app: test
sonataflow.org/service: test-data-index-service
```
job service objects
```
labels:
app: test
sonataflow.org/service: test-jobs-service
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
