tchughesiv commented on code in PR #341:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/341#discussion_r1446101385
##########
controllers/platform/k8s.go:
##########
@@ -243,7 +250,7 @@ func createConfigMap(ctx context.Context, client
client.Client, platform *operat
Name: ps.GetServiceCmName(),
Namespace: platform.Namespace,
Labels: map[string]string{
- workflowproj.LabelApp: platform.Name,
+ workflowproj.LabelService: platform.Name,
Review Comment:
shouldn't this have both labels set? also, this line should remain as-is...
and the new label added. this should match the other objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]