tkobayas commented on code in PR #5677:
URL:
https://github.com/apache/incubator-kie-drools/pull/5677#discussion_r1482376042
##########
drools-drl/drools-drl-parser/pom.xml:
##########
@@ -66,7 +66,32 @@
<groupId>org.antlr</groupId>
<artifactId>antlr-runtime</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.antlr</groupId>
+ <artifactId>antlr4-runtime</artifactId>
+ </dependency>
Review Comment:
At first, I tried to create a separated module `drools-drl10-parser` for the
new parser, but it resulted in circular dependency with `drools-drl-parser`, so
I ended up with migrating the new parser into `drools-drl-parser`. I used a new
package `org.drools.drl10.parser` for a better separation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
