yurloc commented on code in PR #5677:
URL:
https://github.com/apache/incubator-kie-drools/pull/5677#discussion_r1484046003
##########
kie-internal/src/main/java/org/kie/internal/builder/conf/LanguageLevelOption.java:
##########
@@ -25,7 +25,7 @@
*/
public enum LanguageLevelOption implements SingleValueRuleBuilderOption {
- DRL5(false), DRL6(false), DRL6_STRICT(true);
+ DRL5(false), DRL6(false), DRL6_STRICT(true), DRL10(false);
Review Comment:
Temporarily, yes. But it should be removed in the final step in my opinion.
1. The language level stays the same. We're just changing an implementation
detail that deals with how the source code in DRL6 language is being parsed.
2. Is the language level option a public API? If yes, it's one more reason
not to introduce DRL10. Implementation details should not proliferate to the
public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
