tkobayas commented on code in PR #5677:
URL: 
https://github.com/apache/incubator-kie-drools/pull/5677#discussion_r1484059428


##########
kie-internal/src/main/java/org/kie/internal/builder/conf/LanguageLevelOption.java:
##########
@@ -25,7 +25,7 @@
  */
 public enum LanguageLevelOption implements SingleValueRuleBuilderOption {
 
-    DRL5(false), DRL6(false), DRL6_STRICT(true);
+    DRL5(false), DRL6(false), DRL6_STRICT(true), DRL10(false);

Review Comment:
   > Implementation details should not proliferate to the public API.
   
   @yurloc Totally agreed. I just couldn't come up with other Option to switch 
this implementation. Any idea? (of course, we can change it after merging this 
PR)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to