tiagobento commented on code in PR #2164:
URL:
https://github.com/apache/incubator-kie-tools/pull/2164#discussion_r1503140581
##########
packages/kie-bc-editors/src/bpmn/envelope/BpmnEditor.ts:
##########
@@ -74,4 +74,9 @@ export class BpmnEditorImpl extends GwtEditorWrapper
implements BpmnEditor {
public centerNode(uuid: string) {
window.canvas.centerNode(uuid);
}
+
+ public setTheme(theme: any | undefined) {
+ // Themes are not supported by BPMN Editor
+ return Promise.resolve();
+ }
Review Comment:
I know it doesn't make any difference, but who knows what the future holds?
:D
Could we not use `any | undefined` here, and do `EditorTheme | undefined`
instead, to keep consistency with the other implementations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
