handreyrc commented on PR #2164:
URL:
https://github.com/apache/incubator-kie-tools/pull/2164#issuecomment-1969072730
Hi @tiagobento,
I made the changes you suggested and it works well. Basically I added a
subscription for the Theme value right after the editor is created and I
removed the kogitoEditor_setTheme.
However, like in your code sample above, we are unsubscribing for the theme
right after consuning it in the initialization, so it won't listen to theme
changes if the diagram is already loaded (KogitoEditor_setTheme was my hook for
changing the theme in this scenario).
Considering the subscription approach, I removed the "unsubscribe" and it
solves the issue. What we need is some sort of permanent subscription to keep
watching theme changes.
The question is:
- Is there some sort of issue if we do not unsubscribe for that shared
value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
