handreyrc commented on PR #2164: URL: https://github.com/apache/incubator-kie-tools/pull/2164#issuecomment-1992664267
> Hi @handreyrc, I tested the changes I have these 4 comments: > > 1. After creating of a new SW file, the content is not set and the diagram is always in the light mode >  > 2. The zoom percentages are always in the light mode >  > 3. Keyboards shortcuts are always in the light mode >  > 4. When the SW file is changed to some incorrect form and the mode is switched, the diagram remains in the previous mode. (This is probably caused by the fact that the diagram is not reloaded when there is an error in the editor) >  Hey @tomasdavidorg, I worked on the items you pointed above. 1- Dark theme was added to the Error Page. The canvas was implemented in a way that if there are errors, the Error page is presented and no further rendering happens until we have a valid diagram. So if the Error Page is presented with dark theme set and then the theme is changed to light, the error page will remain dark and vice-versa. Changing this behavior may have implications because it is liked to wokflow loading as well, so if we really need to change the theme in this scenario we could consider doing it in a separate PR. 2- Dark Theme was added to the zoombar combobox. 3- Grey background was added to the Keyboard shortcuts modal on dark mode. 4- Theme change in workflows with errors. I didn't consider the behavior of not be possible to reload a broken workflow in my previous implementation, good catch. It was looking alful because the diagram is not reloaded but the background and state selection color pattern changes. In fact the non reloading behavior is on purpose, so if the worflow is broken it remains visible and functional on the canvas. Following this behavior, no theme at all is applied to the broken workflows, however, when it gets valid again the theme applied. Please, could take a look again at these items and share your thoughts? Thanks!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
